Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hyperlinks #313

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

feat: hyperlinks #313

wants to merge 5 commits into from

Conversation

meowgorithm
Copy link
Member

@meowgorithm meowgorithm commented Jun 4, 2024 •
edited
Loading 

str := lipgloss.NewStyle().
    Foreground(lipgloss.Color(63)).
    Underline(true).
    Hyperlink("https://charm.sh").
    Render("Charm!")

Closes #220.

@meowgorithm
Copy link
Member Author

meowgorithm commented Jun 4, 2024 •
edited
Loading

Getting this right will be more work that we thought, namely because of wrapping. Consider the following:

marmalinks.mov

The issue with the styling being removed on wrap is also present here. Ideally we fix these in tandem.

@meowgorithm meowgorithm mentioned this pull request Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymanbagabas aymanbagabas Awaiting requested review from aymanbagabas aymanbagabas will be requested when the pull request is marked ready for review aymanbagabas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OSC 8 (hyperlink) supports.
1 participant
@meowgorithm