Clarify "Load Model" SafeTensors documentation #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Load Model" node description inaccurately implied that SafeTensors wasn't supported. This was presumably because the documentation in question was split between two files, and only one was updated. This commit consolidates the supported file type documentation in one file, so that this bug is less likely to happen again. This also avoids making the description tooltip unwieldily verbose, as would have happened if I had instead edited the description in-place. Also note in the documentation that SafeTensors should be used for better security, since it's not really reasonable to expect users to read the Spandrel GitHub README to find that.
joeyballentine
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Load Model" node description inaccurately implied that SafeTensors wasn't supported. This was presumably because the documentation in question was split between two files, and only one was updated.
This PR consolidates the supported file type documentation in one file, so that this bug is less likely to happen again. This also avoids making the description tooltip unwieldily verbose, as would have happened if I had instead edited the description in-place.
Also note in the documentation that SafeTensors should be used for better security, since it's not really reasonable to expect users to read the Spandrel GitHub README to find that.