Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified crop node #1996

Merged
merged 4 commits into from
Aug 14, 2023
Merged

Conversation

RunDevelopment
Copy link
Member

This unifies the Crop Border/Edges/Offsets nodes into one Crop node.

image

Other changes:

  • Removed Crop Border/Edges/Offsets and added a migration for the new Crop node.
  • Renamed "Crop (Content)" to "Crop Content".
  • Changed order of inputs compared to Crop Edges/Offsets. Inputs are now consistently in order X then Y.

@joeyballentine
Copy link
Member

I think we can do even better. Crop (border) is just crop (edges) with all the sizes linked together. We have an input group that can link number inputs now dont we?

@RunDevelopment
Copy link
Member Author

I think we can do even better. Crop (border) is just crop (edges) with all the sizes linked together. We have an input group that can link number inputs now dont we?

Linked inputs don't work for connections. So you would need to manually make 4 connections to remove a constant border.

That being said, maybe linked inputs should affect connections? So if you connect an edge to an input that is linked with other inputs, chainner automatically creates edges to all inputs. Same for removing edges.

If we do go with linked inputs, then Create Border/Edges would be trivial to unify.

@joeyballentine
Copy link
Member

That sounds good to me and makes sense to do

@theflyingzamboni
Copy link
Collaborator

Request to change Crop Content to Crop To Content. A bit more accurate.

@RunDevelopment
Copy link
Member Author

Request to change Crop Content to Crop To Content. A bit more accurate.

Done.

@joeyballentine joeyballentine merged commit ab1818d into chaiNNer-org:main Aug 14, 2023
14 checks passed
@RunDevelopment RunDevelopment deleted the unified-crop-node branch August 14, 2023 22:06
stonerl pushed a commit to stonerl/chaiNNer that referenced this pull request Aug 14, 2023
* Unified crop node

* Fixed crop node

* Crop to Content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants