-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified crop node #1996
Unified crop node #1996
Conversation
I think we can do even better. Crop (border) is just crop (edges) with all the sizes linked together. We have an input group that can link number inputs now dont we? |
Linked inputs don't work for connections. So you would need to manually make 4 connections to remove a constant border. That being said, maybe linked inputs should affect connections? So if you connect an edge to an input that is linked with other inputs, chainner automatically creates edges to all inputs. Same for removing edges. If we do go with linked inputs, then Create Border/Edges would be trivial to unify. |
That sounds good to me and makes sense to do |
Request to change Crop Content to Crop To Content. A bit more accurate. |
Done. |
* Unified crop node * Fixed crop node * Crop to Content
This unifies the Crop Border/Edges/Offsets nodes into one Crop node.
Other changes: