Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements #1554

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Various improvements #1554

merged 5 commits into from
Oct 22, 2024

Conversation

frankrousseau
Copy link
Contributor

Problem

  • There is no way to limitate a shared filter to a department
  • It's not possible to make Kitsu dark by default

Solution

  • Allow to specify a department_id on shared filters
  • Add a setting at the instance level to set it dark by default or not

NicoPennec
NicoPennec reviewed Oct 22, 2024
View reviewed changes
src/components/modals/EditSearchFilterModal.vue Outdated Show resolved Hide resolved
src/components/widgets/ComboboxDepartment.vue Outdated Show resolved Hide resolved
src/components/widgets/ComboboxDepartment.vue Outdated Show resolved Hide resolved
@NicoPennec NicoPennec merged commit 4f9478a into cgwire:master Oct 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoPennec NicoPennec NicoPennec left review comments

Assignees

@frankrousseau frankrousseau

Labels
documentation needed push to changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankrousseau @NicoPennec