Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve entity filtering #1505

Merged
merged 6 commits into from
Aug 5, 2024
Merged

Conversation

NicoPennec
Copy link
Member

@NicoPennec NicoPennec commented Aug 2, 2024

Problem
On entity lists,

  • boolean filtering created from the filter builder doesn't work as expected.
  • filtering a numeric metadata with a value at "0" doesn't work.
  • after a metadata update, the filtering result is not updated.

Solution

  • Fix metadata filtering with a form improvement in the filter builder.
  • Fix number metadata filtering with zero.
  • Run filter update after every entity update.

In addition, bump minor outdated npm dependencies and clean unit tests.

@NicoPennec NicoPennec force-pushed the fix/filtering branch 2 times, most recently from e1fa9e9 to 495fd13 Compare August 5, 2024 22:15
@NicoPennec NicoPennec merged commit 5bbbcba into cgwire:master Aug 5, 2024
5 checks passed
@NicoPennec NicoPennec deleted the fix/filtering branch August 5, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants