FIX: Keep standalone flag after reloading #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Library mode introduced 'standalone' flag for bots running as a process. This flag instruct the bot to handle signals, including SIGTERM. Unfortuneatly, this flag weren't preserved when reloading the bot, what caused not being able to gracefully stop reloaded bots. Reloading is used when logrotate with recommended configuration is enabled, what means that this bug affects all 3.2.0 installations from native packages after first logrotate.
kamil-certat
added
the
bug
sebix
reviewed
Aug 24, 2023
sebix
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library mode introduced 'standalone' flag for
bots running as a process. This flag instruct
the bot to handle signals, including SIGTERM.
Unfortuneatly, this flag weren't preserved
when reloading the bot, what caused not being
able to gracefully stop reloaded bots.
Reloading is used when logrotate with recommended
configuration is enabled, what means that
this bug affects all 3.2.0 installations
from native packages after first logrotate.