ENH: message: show reason for InvalidKey exception #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagner-intevation
force-pushed
the
enh-invalid-key-message
branch
from
6db9538
to
9b288b1
Compare
sebix
added
feature
wagner-intevation
force-pushed
the
enh-invalid-key-message
branch
from
9b288b1
to
e29178e
Compare
kamil-certat
approved these changes
Aug 28, 2023
intelmq/lib/exceptions.py
Outdated
| message = "invalid key %s" % repr(key) | ||
| def __init__(self, key: str, additional_text: Optional[str] = None): | ||
| postfix = f' {additional_text}' if additional_text else '' | ||
| message = f"invalid key {key!r}{postfix}" |
There was a problem hiding this comment.
Why not just:
message = f"invalid key {key!r} {additional_text or ''}"
intelmq/lib/message.py
Outdated
| if subitem: | ||
| return HARMONIZATION_KEY_FORMAT.match(key) | ||
| return HARMONIZATION_KEY_FORMAT.match(key), f'Does not match regular expression {HARMONIZATION_KEY_FORMAT.pattern}' | ||
| return False |
There was a problem hiding this comment.
Cation: Default case return just one item instead of expected tuple
if the user wants to add a field with an invalid key, the reason was not clear now the error message says that either the key is not allowed in the harmonization configuration or the key does not match the regular expression (for extra keys), e.g. is not lower case etc.
wagner-intevation
force-pushed
the
enh-invalid-key-message
branch
from
e29178e
to
dc758e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the user wants to add a field with an invalid key, the reason was not clear
now the error message says that either