Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #2125 #2386

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Fixed #2125 #2386

merged 3 commits into from
Jul 18, 2023

Conversation

sebkuf
Copy link
Contributor

@sebkuf sebkuf commented Jul 13, 2023

Fixes #2125, fix syntax in separate-raws-table.sql

@sebix
Copy link
Member

sebix commented Jul 14, 2023

@sebkuf Can you please include in the commit message either fixes #2386 or fixes certtools/intelmq#2386 / remove the :, so that the commit is linked to the issue and closes it once merged? See also https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

And the commit message could be more descriptive too, for example

fix syntax in separate-raws-table.sql  // short description

contrib/eventdb/separate-raws-table.sql was missing some commas in the column list, breaking SQL syntax
this adds commas to all columns  // long description

fixes certtools/intelmq#2386  // linking the issue

@sebkuf sebkuf changed the title Fixed :#2125 Fixed #2125 Jul 14, 2023
@kamil-certat
Copy link
Contributor

Please update the commit message and add a short changelog entry

contrib/eventdb/separate-raws-table.sql was missing some commas in the column list, breaking SQL syntax
this adds commas to all columns

Fixes certtools#2125
@kamil-certat kamil-certat requested a review from sebix July 18, 2023 09:39
@sebix sebix merged commit 2331bda into certtools:develop Jul 18, 2023
24 checks passed
@sebix sebix added this to the 3.2.0 milestone Jul 18, 2023
@sebkuf sebkuf deleted the fix_missing_kommas branch July 19, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing commas in SQL query for separate Events table
3 participants