Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Setting Nameservers for DNS01 Self Check" example #528

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update "Setting Nameservers for DNS01 Self Check" example #528

wants to merge 1 commit into from

Conversation

Skulblaka
Copy link

I tried to apply the example for configuration alternative servers used for the DNS01 self check, since I'm having trouble with that on my DigitalOcean managed cluster.

Here are the commands I ran:

kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v1.3.0/cert-manager.yaml
kubectl --namespace cert-manager patch --type json deployment cert-manager -p "$(cat cert-manager.patch.json)"

cert-manager.patch.json:

[
  {
    "op": "add",
    "path": "/spec/template/spec/containers/0/args/-",
    "value": "--dns01-recursive-nameservers-only"
  },
  {
    "op": "add",
    "path": "/spec/template/spec/containers/0/args/-",
    "value": "--dns01-recursive-nameservers=\"8.8.8.8:53,1.1.1.1:53\""
  }
]

I get a Crashloopbackoff from the cert-manager pod however: Error: error validating options: invalid DNS server (address 8.8.8.8:53,1.1.1.1:53: too many colons in address): 8.8.8.8:53,1.1.1.1:53

After changing my patch to like the following it worked as expected:

[
  {
    "op": "add",
    "path": "/spec/template/spec/containers/0/args/-",
    "value": "--dns01-recursive-nameservers-only"
  },
  {
    "op": "add",
    "path": "/spec/template/spec/containers/0/args/-",
    "value": "--dns01-recursive-nameservers=\"8.8.8.8:53\""
  },
  {
    "op": "add",
    "path": "/spec/template/spec/containers/0/args/-",
    "value": "--dns01-recursive-nameservers=\"1.1.1.1:53\""
  }
]

I guess the "Comma separated string" part isn't valid anymore.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2021
@jetstack-bot
Copy link
Contributor

Hi @Skulblaka. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Skulblaka
To complete the pull request process, please assign jakexks after the PR has been reviewed.
You can assign the PR to them by writing /assign @jakexks in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 21, 2021
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2022
@jetstack-bot
Copy link
Contributor

@Skulblaka: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants