Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc about new option default-cleanup-policy #1197

Open
wants to merge 6 commits into
base: release-next
Choose a base branch
from

Conversation

RomanenkoDenys
Copy link

This is doc part of cert-manager/cert-manager#5158

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 12, 2023
@netlify
Copy link

netlify bot commented Mar 12, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 601b6e8
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/642fcecd3d67d2000813d374
😎 Deploy Preview https://deploy-preview-1197--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@maelvls maelvls changed the base branch from master to release-next March 21, 2023 14:11
@maelvls maelvls force-pushed the certificate-owner-ref-change branch from d5b9404 to aa9c31a Compare March 21, 2023 14:13
@maelvls
Copy link
Member

maelvls commented Mar 21, 2023

Thanks for this PR! I left a couple of minor comments.

I changed and the base branch to release-next and rebased on top of it.

@maelvls
Copy link
Member

maelvls commented Mar 21, 2023

/approve

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls, RomanenkoDenys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2023
content/docs/usage/certificate.md Outdated Show resolved Hide resolved
content/docs/usage/certificate.md Show resolved Hide resolved
content/docs/usage/certificate.md Outdated Show resolved Hide resolved
RomanenkoDenys and others added 3 commits March 21, 2023 20:55
Co-authored-by: Maël Valais <[email protected]>
Signed-off-by: Denys Romanenko <[email protected]>
Co-authored-by: Maël Valais <[email protected]>
Signed-off-by: Denys Romanenko <[email protected]>
Co-authored-by: Maël Valais <[email protected]>
Signed-off-by: Denys Romanenko <[email protected]>
@RomanenkoDenys
Copy link
Author

Thanks for this PR! I left a couple of minor comments.

I changed and the base branch to release-next and rebased on top of it.

Thank you, i apply all suggestions !

@maelvls
Copy link
Member

maelvls commented Mar 22, 2023

Updating the API reference documentation is quite tricky because the scripts/gendocs/generate script hardcodes the "target" branch from which the docs will be generated. You can skip updating the API reference page in this PR.

@RomanenkoDenys
Copy link
Author

Updating the API reference documentation is quite tricky because the scripts/gendocs/generate script hardcodes the "target" branch from which the docs will be generated. You can skip updating the API reference page in this PR.

I cannot update api reference in this PR

Copy link
Member

@maelvls maelvls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the documentation. Apart from two suggestion, it looks good to go.

Maybe it would require a bit more context as to why someone would use that feature, but the current documentation is already good.

I'll LGTM after the suggestion is reviewed.

content/docs/usage/certificate.md Show resolved Hide resolved
content/docs/usage/certificate.md Outdated Show resolved Hide resolved
RomanenkoDenys and others added 2 commits April 7, 2023 11:05
Co-authored-by: Maël Valais <[email protected]>
Signed-off-by: Denys Romanenko <[email protected]>
Co-authored-by: Maël Valais <[email protected]>
Signed-off-by: Denys Romanenko <[email protected]>
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2023
@jetstack-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants