updated preflight and added debian tasks #300
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guits
reviewed
Jun 7, 2024
guits
reviewed
Jun 10, 2024
tchaikov
changed the title
0lzi
changed the title
guits
reviewed
Jul 1, 2024
| - name: enable red hat ceph storage tools repository | ||
| rhsm_repository: | ||
| name: "rhceph-{{ ceph_rhcs_version }}-tools-for-rhel-{{ ansible_facts['distribution_major_version'] }}-{{ ansible_facts['architecture'] }}-rpms" | ||
| - name: Import specific OS-related tasks |
There was a problem hiding this comment.
TASK [Import specific OS-related tasks] ****************************************
task path: /home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/cephadm-preflight.yml:48
fatal: [ceph-node0]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/[]' on the Ansible Controller.
fatal: [ceph-node1]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/[]' on the Ansible Controller.
fatal: [ceph-node2]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/[]' on the Ansible Controller.
fatal: [ceph-node3]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/[]' on the Ansible Controller.
fatal: [ceph-node4]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/[]' on the Ansible Controller.
fatal: [ceph-node5]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/[]' on the Ansible Controller.
fatal: [client0]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/[]' on the Ansible Controller.
fatal: [client1]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/[]' on the Ansible Controller.
There was a problem hiding this comment.
why do we have to make it that 'complex' ?
I didn't test the following myself but I'd expect it to work as expected:
import_tasks: tasks/redhat.yml
- name: Import specific OS-related tasks
import_tasks: "{{ item }}"
with_first_found:
- "{{ ansible_distribution }}.yml"any issue with it?
There was a problem hiding this comment.
I used the more complex way as when i did local linting it complained about import_tasks
WARNING Listing 1 violation(s) that are fatal
syntax-check[specific]: You cannot use loops on 'import_tasks' statements. You should use 'include_tasks' instead.
cephadm-preflight.yml:48:7
Which it complained about in the latest job here
There was a problem hiding this comment.
there was also this on the previous job run
Using /home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/tests/functional/ansible.cfg as config file
ERROR! the role 'ceph-defaults' was not found in /home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/roles:/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional:/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional
The error appears to be in '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/collect-logs.yml': line 6, column 15, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:
import_role:
name: ceph-defaults
^ here
There was a problem hiding this comment.
Here is some links I looked over :
There was a problem hiding this comment.
there was also this on the previous job run
Using /home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/tests/functional/ansible.cfg as config file ERROR! the role 'ceph-defaults' was not found in /home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/roles:/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional:/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional The error appears to be in '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/collect-logs.yml': line 6, column 15, but may be elsewhere in the file depending on the exact syntax problem. The offending line appears to be: import_role: name: ceph-defaults ^ here
you can ignore this error
There was a problem hiding this comment.
I used the more complex way as when i did local linting it complained about import_tasks
WARNING Listing 1 violation(s) that are fatal syntax-check[specific]: You cannot use loops on 'import_tasks' statements. You should use 'include_tasks' instead. cephadm-preflight.yml:48:7Which it complained about in the latest job here
yeh the linter error makes sense, then just use include_tasks instead
There was a problem hiding this comment.
I have ran this locally against my own inv file and don't get the same error than what is in the CI
TASK [Import specific OS-related tasks] ****************************************
task path: /home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/cephadm-preflight.yml:48
fatal: [ceph-node0]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/[]' on the Ansible Controller.
fatal: [ceph-node1]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/[]' on the Ansible Controller.
fatal: [ceph-node2]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/[]' on the Ansible Controller.
fatal: [ceph-node3]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/[]' on the Ansible Controller.
fatal: [ceph-node4]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/[]' on the Ansible Controller.
fatal: [ceph-node5]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/[]' on the Ansible Controller.
fatal: [client0]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/[]' on the Ansible Controller.
fatal: [client1]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/[]' on the Ansible Controller.
There was a problem hiding this comment.
simplfying the include_tasks shows a path, but still not available.
- name: Import specific OS-related tasks
include_tasks: "tasks/{{ ansible_facts['distribution'] }}.yml"
I am wondering if the tasks folder path needs adjusting, as the Vagrantfile is using ansible.playbook = '../cephadm-preflight.yml'
TASK [Import specific OS-related tasks] ****************************************
task path: /home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/cephadm-preflight.yml:48
fatal: [ceph-node0]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/tasks/CentOS.yml' on the Ansible Controller.
fatal: [ceph-node1]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/tasks/CentOS.yml' on the Ansible Controller.
fatal: [ceph-node2]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/tasks/CentOS.yml' on the Ansible Controller.
fatal: [ceph-node3]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/tasks/CentOS.yml' on the Ansible Controller.
fatal: [ceph-node4]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/tasks/CentOS.yml' on the Ansible Controller.
fatal: [ceph-node5]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/tasks/CentOS.yml' on the Ansible Controller.
fatal: [client0]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/tasks/CentOS.yml' on the Ansible Controller.
fatal: [client1]: FAILED! =>
reason: Could not find or access '/home/jenkins-build/build/workspace/cephadm-ansible-prs-el9-functional/tasks/CentOS.yml' on the Ansible Controller.
da9b808
to
05ced0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved redhat and ubuntu related tasks to their own tasks.yml and added one for debian, ran the tasks against debian 12 boxes we have and it worked. If there is any documentation for running tests?