do not always error out while checking for existence of resources #151
Conversation
|
I'm a bit divided b/n where the handling should happen, like, err returned from the load function can't always be same as returned by api server. To be moved inside the function it needs to copied at a couple of places, pls review. |
| if k8serrors.IsNotFound(err) { | ||
| r.log.Info("Driver resource does not exist anymore, skipping reconcile") | ||
| return nil | ||
| } |
There was a problem hiding this comment.
I think this is should not be here because it is returning nil for all the not found errors, like if the imageset configmap not found we will get here and we return nil to stop the reconcile which is not correct.
There was a problem hiding this comment.
I agree.
The inner function needs to return a different custom error so the top-most function can make a decision based on that concrete error
controllers also get reconciles for deletion events and it may happen that resource at api server be deleted first before it being purged from cache and during that time if we error out the reconciliation will never be successful in standard conditions. Signed-off-by: Leela Venkaiah G <[email protected]>
| @@ -130,6 +131,10 @@ func (r *ClientProfileReconciler) Reconcile(ctx context.Context, req ctrl.Reques | |||
|
|
|||
| func (r *ClientProfileReconcile) reconcile() error { | |||
| if err := r.loadAndValidate(); err != nil { | |||
| if k8serrors.IsNotFound(err) && r.clientProfile.UID == "" { | |||
There was a problem hiding this comment.
@leelavg wouldn't it make more sense to investigate the error object to see the target of the not found error?
| @@ -226,6 +226,10 @@ func (r *DriverReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr | |||
| func (r *driverReconcile) reconcile() error { | |||
| // Load the driver desired state based on driver resource, operator config resource and default values. | |||
| if err := r.LoadAndValidateDesiredState(); err != nil { | |||
| if k8serrors.IsNotFound(err) && r.driver.UID == "" { | |||
controllers also get reconciles for deletion events and it may happen that resource at api server be deleted first before it being purged from cache and during that time if we error out the reconciliation will never be successful in standard conditions.
fixes: #78