Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Wait for on export #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

savaki
Copy link
Contributor

@savaki savaki commented Jul 15, 2018

  • onExport is now included in the set of goroutines managed by wg
  • moved calls of wg.Add and wg.Done closer together so the relationship is clearer

Resolves issue, #19

@rakyll rakyll requested a review from semistrict August 2, 2018 19:32
@@ -231,9 +231,6 @@ func buildConfig(opts ...Option) (config, error) {
if c.output == nil {
c.output = os.Stderr
}
if c.onExport == nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't removing this mean that the later call to onExport will panic?

savaki added a commit that referenced this pull request Sep 5, 2018
* honors `ochttp.Server#FormatSpanName` to set http.url
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants