improve peer closing logic

cenkalti · Jun 27, 2023 · 3eb8953 · 3eb8953
1 parent 742c1b8
commit 3eb8953
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/internal/peer/peer.go b/internal/peer/peer.go
@@ -130,7 +130,6 @@ func (p *Peer) Close() {
  p.downloadSpeed.Stop()
  p.uploadSpeed.Stop()
  <-p.doneC
- p.Closed = true
 }
 
 // Done returns a channel that is closed when a peers run loop is ended.

diff --git a/torrent/torrent_close.go b/torrent/torrent_close.go
@@ -25,7 +25,11 @@ func (t *torrent) close() {
 }
 
 func (t *torrent) closePeer(pe *peer.Peer) {
+ if pe.Closed {
+ return
+ }
  pe.Close()
+ pe.Closed = true
  if pd, ok := t.pieceDownloaders[pe]; ok {
  t.closePieceDownloader(pd)
  }