Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soloseng/using-node-version-18 #76

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

soloseng
Copy link
Contributor

@soloseng soloseng commented Nov 17, 2022

Description

A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?

Other changes

  • Removed solidity-bytes-utils from dev dependencies, as it did not seem to be in use, and updating to version 0.8.0 caused the following error:
    Error: Incompatible EIP155-based V 38 and chain id 31337. See the Common parameter of the Transaction constructor to set the chain id.

Tested

An explanation of how the changes were tested or an explanation as to why they don't need to be.

Related issues

@socket-security
Copy link

socket-security bot commented Nov 17, 2022

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
[email protected] (added) binding.gyp package.json via [email protected], @nomicfoundation/[email protected], [email protected]
[email protected] (added) install package.json via [email protected]
[email protected] (added) install package.json via [email protected], @nomicfoundation/[email protected], [email protected]
[email protected] (added) postinstall package.json
🫣 Native code

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

Package Location Source
[email protected] (added) binding.gyp package.json via [email protected], @nomicfoundation/[email protected], [email protected]
😵‍💫 Bin script confusion

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack

Consider removing one of the conflicting packages. Packages should only export bin scripts with their name

Package Bin script Source
@ethereumjs/[email protected] (added) rlp package.json
@nomicfoundation/[email protected] (added) rlp package.json via [email protected]
[email protected] (added) rlp package.json via [email protected], @ethereum-waffle/[email protected], [email protected], [email protected]
[email protected] (added) rlp package.json
Pull request report summary
Issue Status
Install scripts ⚠️ 4 issues
Native code ⚠️ 1 issue
Bin script confusion ⚠️ 4 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

@soloseng
Copy link
Contributor Author

soloseng commented Dec 6, 2023

Blocked by hardhat compatibility issues. Might be worth migrating to foundry.

@soloseng
Copy link
Contributor Author

Hardhat created a fork of ethereumjs monorepo, that is no longer in sync with the original repo.

Since celo also has a fork of ethereumjs monorepo for use with the ganache fork, upgrading hardhat now requires a fork of their fork to make it celo compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up and Update Dependencies
2 participants