ethclient allow empty uncles #228
Conversation
The first blocks of the celo chain lacked the uncles field, so to support retrieveing them with the ethclient.Client this modification is required.
| if head.UncleHash != types.EmptyUncleHash && len(body.UncleHashes) == 0 { | ||
| // In celo before the ginerbread hardfork, blocks had no uncles hash and no | ||
| // uncles, so in those cases it is legitimate to have an empty uncles hash. | ||
| var emptyHash common.Hash |
There was a problem hiding this comment.
Should we allow this only in a specific range of block numbers?
There was a problem hiding this comment.
That would be nice but I don't see any way to do it without some fairly invasive changes to the interface. Let me know if you see a way to do this neatly.
There was a problem hiding this comment.
I though of something like this, just to limit the scope of the check:
var emptyHash common.Hash
if head.UncleHash != emptyHash && len(body.UncleHashes) == 0 && head.Number.Cmp(big.NewInt(12345)) < 0 {
return nil, errors.New("server returned empty uncle list but block header indicates uncles")
}That would also require that we know in which block the first uncle is written.
There was a problem hiding this comment.
So yeah, that is the thing getting the knowledge of the block (gingerbread block) to the right place, as I see it either you pass it through the constructor or as a parameter to the method, but either way, you'd be looking at a lot of changes.
There was a problem hiding this comment.
Ok, now I get it.
The first blocks of the celo chain lacked the uncles field
It sounded like it was only for the first couple of blocks, not until gingerbread.
The first blocks of the celo chain (till gingerbread) lacked the uncles field, so to support retrieving them with the ethclient.Client this modification is required.
The first blocks of the celo chain (till gingerbread) lacked the uncles field, so to support retrieving them with the ethclient.Client this modification is required.
The first blocks of the celo chain (till gingerbread) lacked the uncles field, so to support
retrieving them with the ethclient.Client this modification is required.
Discovered through https://github.com/celo-org/celo-blockchain-planning/issues/363