Refactor e2e tests #212
Merged
Refactor e2e tests #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezdac
force-pushed
the
ezdac/issue-177-e2e-test
branch
from
b35cbe1
to
0723419
Compare
ezdac
force-pushed
the
ezdac/issue-177-e2e-test
branch
2 times, most recently
from
cd4c33a
to
cb9fe72
Compare
ezdac
force-pushed
the
ezdac/issue-177-e2e-test
branch
from
cb9fe72
to
7f0bc60
Compare
karlb
reviewed
Sep 20, 2024
This reverts commit 25314bc.
ezdac
force-pushed
the
ezdac/issue-177-e2e-test
branch
from
a07f072
to
eb19209
Compare
karlb
reviewed
Sep 24, 2024
ezdac
force-pushed
the
ezdac/issue-177-e2e-test
branch
from
eb19209
to
107e1f3
Compare
karlb
approved these changes
Sep 24, 2024
Since some e2e tests now produce invalidated transactions that remain in the txpool until replaced, the `send_tx.mjs` script required some changes to replace the sent CIP64 transaction. It will get replaced after 2 blocks of producing no receipt. Those changes also required the geth-node to run in periodic --dev mode instead of the on-demand "produce-block-per-transaction" mode, which will unfortunately make the tests run longer than before. The bash scripts and tests itself have also been refactored to make code segments more reusable with the help of functions.
The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways.
ezdac
force-pushed
the
ezdac/issue-177-e2e-test
branch
from
107e1f3
to
a6aa79e
Compare
karlb
pushed a commit
that referenced
this pull request
Oct 11, 2024
* Revert "Temporarily skip fee-currency e2e tests" This reverts commit 25314bc. * Refactor e2e tests Since some e2e tests now produce invalidated transactions that remain in the txpool until replaced, the `send_tx.mjs` script required some changes to replace the sent CIP64 transaction. It will get replaced after 2 blocks of producing no receipt. Those changes also required the geth-node to run in periodic --dev mode instead of the on-demand "produce-block-per-transaction" mode, which will unfortunately make the tests run longer than before. The bash scripts and tests itself have also been refactored to make code segments more reusable with the help of functions. * Fix js waitBlocks * Fix e2e oracle reuse causing exchangeRate error The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. * Remove accidentally checked in comment * Reintroduce geth insta-mine in e2e tests * Add replacement transaction related arguments to send_tx
piersy
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Revert "Temporarily skip fee-currency e2e tests" This reverts commit 25314bc. * Refactor e2e tests Since some e2e tests now produce invalidated transactions that remain in the txpool until replaced, the `send_tx.mjs` script required some changes to replace the sent CIP64 transaction. It will get replaced after 2 blocks of producing no receipt. Those changes also required the geth-node to run in periodic --dev mode instead of the on-demand "produce-block-per-transaction" mode, which will unfortunately make the tests run longer than before. The bash scripts and tests itself have also been refactored to make code segments more reusable with the help of functions. * Fix js waitBlocks * Fix e2e oracle reuse causing exchangeRate error The geth-devmode predeployed "oracle3" is reused throughout the e2e tests for all dynamically deployed fee-currencies. However the tested fee-currencies are never removed from the FeeCurrencyDirectory. This causes the node to try to query exchange-rates for the leftover fee-currencies. This fails, because the oracle associated with the old fee-currency has a different token address assigned and thus causes a revert. This issue is not critical and only causes emission of a log message and some unneccessary evm calls, but it is better practice to clean up the fee-currency from the directory anyways. * Remove accidentally checked in comment * Reintroduce geth insta-mine in e2e tests * Add replacement transaction related arguments to send_tx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #202 - don't merge before that.
Adapts the e2e tests for the fee-currency changes in #202 and refactors the bash-based test-suite to a more modular design.