Add txpool metrics for TxType and FeeCurrency #199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are helpful to track the usage of our fee currency feature.
Adding gauges to track the exact amount of fee currency txs in the tx pool would be possible, but cause a larger diff that is spread out across multiple functions.
I also refrained from adding tracking to the state transition, since no metrics are collected inside the state transition at the moment. I wanted to stay close to the upstream code and correctly tracking the values when changes can be reverted at any time is not straightforward.
See #74.
Example output for the new metrics after running the viem e2e tests: