Add support for legacy transaction signing #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also tweaked the design a little.
piersy
changed the title
palango
reviewed
Jul 4, 2024
palango
reviewed
Jul 8, 2024
Fix typo Co-authored-by: Paul Lange <[email protected]>
palango
reviewed
Jul 8, 2024
palango
approved these changes
Jul 8, 2024
karlb
pushed a commit
that referenced
this pull request
Jul 10, 2024
Adds an overlay signer that handles all celo transaction types before handing off to an upstream signer for non celo transaction types. The overlay signer supports easy addition of new forks and transaction deprecation. Co-authored-by: Paul Lange <[email protected]>
karlb
pushed a commit
that referenced
this pull request
Jul 10, 2024
Adds an overlay signer that handles all celo transaction types before handing off to an upstream signer for non celo transaction types. The overlay signer supports easy addition of new forks and transaction deprecation. Co-authored-by: Paul Lange <[email protected]>
karlb
pushed a commit
that referenced
this pull request
Jul 12, 2024
Adds an overlay signer that handles all celo transaction types before handing off to an upstream signer for non celo transaction types. The overlay signer supports easy addition of new forks and transaction deprecation. Co-authored-by: Paul Lange <[email protected]>
karlb
pushed a commit
that referenced
this pull request
Aug 20, 2024
Adds an overlay signer that handles all celo transaction types before handing off to an upstream signer for non celo transaction types. The overlay signer supports easy addition of new forks and transaction deprecation. Co-authored-by: Paul Lange <[email protected]>
karlb
pushed a commit
that referenced
this pull request
Aug 26, 2024
Adds an overlay signer that handles all celo transaction types before handing off to an upstream signer for non celo transaction types. The overlay signer supports easy addition of new forks and transaction deprecation. Co-authored-by: Paul Lange <[email protected]>
karlb
pushed a commit
that referenced
this pull request
Aug 30, 2024
Adds an overlay signer that handles all celo transaction types before handing off to an upstream signer for non celo transaction types. The overlay signer supports easy addition of new forks and transaction deprecation. Co-authored-by: Paul Lange <[email protected]>
karlb
pushed a commit
that referenced
this pull request
Oct 11, 2024
Adds an overlay signer that handles all celo transaction types before handing off to an upstream signer for non celo transaction types. The overlay signer supports easy addition of new forks and transaction deprecation. Co-authored-by: Paul Lange <[email protected]>
piersy
added a commit
that referenced
this pull request
Oct 15, 2024
Adds an overlay signer that handles all celo transaction types before handing off to an upstream signer for non celo transaction types. The overlay signer supports easy addition of new forks and transaction deprecation. Co-authored-by: Paul Lange <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces an overlay celo signer that is able to handle all celo related transaction signing and hand off to an upstream signer for everything non celo.
Also adds signing support for celo legacy transactions, which we need because signers are required to derive transaction senders, so without singers we won't be able to correctly serve historical transactions over the RPC API.
Also adds support for deprecating transactions.
In it's current form the code considers that celo legacy transactions (type 0 with feeCurrency, gatewayFee & gatewayFeeRecipient) and CeloDynamicFeeTx (type 124) will be deprecated by the cel2 fork. This may not be the case but it is very easy to change that.