refactor(store): write actual share size to ods #3863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
cristaloleg
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3863 +/- ##
==========================================
+ Coverage 44.83% 45.17% +0.34%
==========================================
Files 265 314 +49
Lines 14620 21800 +7180
==========================================
+ Hits 6555 9849 +3294
- Misses 7313 10932 +3619
- Partials 752 1019 +267 ☔ View full report in Codecov by Sentry. |
Wondertan
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to write const for share size in file header. Instead we can write actual size from provided eds.