Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring!(share): migrating to go-square v2 types #3782

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

refactoring!(share): migrating to go-square v2 types #3782

wants to merge 19 commits into from
+1,573 −2,025

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Sep 27, 2024 •
edited
Loading

Fixes #3770
Fixes #3824

PLEASE NOTE: We are not backward compatible since the app version has changed

@vgonkivs vgonkivs added the kind:refactor Attached to refactoring PRs label Sep 27, 2024
@vgonkivs vgonkivs self-assigned this Sep 27, 2024
@vgonkivs vgonkivs force-pushed the migrate_to_go_square_types branch 2 times, most recently from e55c5a3 to 9daf0e7 Compare October 1, 2024 15:05
cristaloleg
cristaloleg reviewed Oct 2, 2024
View reviewed changes
square/namespace.go Outdated Show resolved Hide resolved
cristaloleg
cristaloleg reviewed Oct 2, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
cristaloleg
cristaloleg reviewed Oct 2, 2024
View reviewed changes
blob/service.go Outdated Show resolved Hide resolved
cristaloleg
cristaloleg reviewed Oct 2, 2024
View reviewed changes
blob/service.go Outdated Show resolved Hide resolved
cristaloleg
cristaloleg reviewed Oct 2, 2024
View reviewed changes
square/shwap/row.go Outdated Show resolved Hide resolved
cristaloleg
cristaloleg reviewed Oct 2, 2024
View reviewed changes
cmd/util_test.go Outdated Show resolved Hide resolved
@vgonkivs vgonkivs force-pushed the migrate_to_go_square_types branch 2 times, most recently from 1506ac9 to 9549956 Compare October 3, 2024 10:00
cristaloleg
cristaloleg reviewed Oct 3, 2024
View reviewed changes
blob/blob.go Outdated Show resolved Hide resolved
@vgonkivs vgonkivs force-pushed the migrate_to_go_square_types branch 2 times, most recently from 6adac82 to aad5872 Compare October 7, 2024 13:26
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.40258% with 308 lines in your changes missing coverage. Please review.

Project coverage is 45.02%. Comparing base (2469e7a) to head (28de789).
Report is 342 commits behind head on main.

Files with missing lines Patch % Lines
nodebuilder/da/service.go 0.00% 30 Missing ⚠️
share/root.go 32.50% 18 Missing and 9 partials ⚠️
share/ipld/namespace_data.go 37.03% 10 Missing and 7 partials ⚠️
share/eds/rsmt2d.go 57.14% 10 Missing and 5 partials ⚠️
share/shwap/row_namespace_data.go 50.00% 9 Missing and 6 partials ⚠️
share/eds/byzantine/share_proof.go 25.00% 12 Missing ⚠️
api/gateway/share.go 16.66% 10 Missing ⚠️
nodebuilder/share/share.go 0.00% 10 Missing ⚠️
share/shwap/p2p/bitswap/getter.go 16.66% 10 Missing ⚠️
blob/blob.go 70.00% 7 Missing and 2 partials ⚠️
... and 40 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3782      +/-   ##
==========================================
+ Coverage   44.83%   45.02%   +0.19%     
==========================================
  Files         265      311      +46     
  Lines       14620    21736    +7116     
==========================================
+ Hits         6555     9787    +3232     
- Misses       7313    10904    +3591     
- Partials      752     1045     +293

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgonkivs vgonkivs force-pushed the migrate_to_go_square_types branch 3 times, most recently from cdd930a to 3c01d85 Compare October 8, 2024 12:38
This was referenced Oct 9, 2024
Closed
Open
@vgonkivs vgonkivs force-pushed the migrate_to_go_square_types branch 2 times, most recently from b1dff79 to e49fc28 Compare October 10, 2024 10:04
@vgonkivs vgonkivs marked this pull request as ready for review October 10, 2024 10:30
evan-forbes
evan-forbes reviewed Oct 16, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
Wondertan
Wondertan approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive. Good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@cmwaters cmwaters Awaiting requested review from cmwaters

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@evan-forbes evan-forbes Awaiting requested review from evan-forbes

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

@cristaloleg cristaloleg Awaiting requested review from cristaloleg cristaloleg is a code owner

@rootulp rootulp Awaiting requested review from rootulp

Requested changes must be addressed to merge this pull request.

Assignees

@vgonkivs vgonkivs

Labels
kind:break! Attached to breaking PRs kind:refactor Attached to refactoring PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to celestia-app v3.0.0-rc0 [Feature Request]: Migrate to go-square types
8 participants
@vgonkivs @codecov-commenter @cristaloleg @rootulp @walldiss @Wondertan @renaynay @evan-forbes