Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prebuilt binaries with Ledger support (backport #2872) #2893

Merged
merged 2 commits into from
Dec 4, 2023
Merged

feat: prebuilt binaries with Ledger support (backport #2872) #2893

merged 2 commits into from
Dec 4, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 4, 2023 •
edited by rootulp
Loading

This is an automatic backport of pull request #2872 done by Mergify.

After this merges, I plan on cutting 1.5.0-rc0.

@rootulp @mergify
feat: prebuilt binaries with Ledger support (#2872)
ba01a7e 
Closes #2729

This PR removes [checksum
signing](https://goreleaser.com/customization/sign/) because
goreleaser/goreleaser-cross#58.

## Testing

The assets on
https://github.com/rootulp/celestia-app/releases/tag/v1.0.0-rc52

OS | Platform | Ledger support
--- | --- | ---
Darwin | arm64 | ✅
Darwin | amd64 | ✅
Linux | arm64 |
Linux | amd64 | ✅

(cherry picked from commit 0e94856)

# Conflicts:
#	.github/workflows/ci-release.yml
#	README.md
#	scripts/signing/verify-signature.sh
@mergify mergify bot added the conflicts label Dec 4, 2023
@mergify mergify bot requested a review from cmwaters as a code owner December 4, 2023 16:08
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 4, 2023

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@celestia-bot celestia-bot requested a review from a team December 4, 2023 16:08
@github-actions github-actions bot added the bot item was created by a bot label Dec 4, 2023
@rootulp rootulp marked this pull request as draft December 4, 2023 18:14
@rootulp rootulp self-assigned this Dec 4, 2023
@rootulp rootulp marked this pull request as ready for review December 4, 2023 18:17
@rootulp rootulp merged commit 01e080b into v1.x Dec 4, 2023
25 checks passed
@rootulp rootulp deleted the mergify/bp/v1.x/pr-2872 branch December 4, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootulp rootulp rootulp approved these changes

@staheri14 staheri14 staheri14 approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

@cmwaters cmwaters Awaiting requested review from cmwaters

Assignees

@rootulp rootulp

Labels
bot item was created by a bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rootulp @staheri14 @evan-forbes