ci: PRs titles must have a conventional commit prefix #2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSevey
approved these changes
Oct 13, 2023
staheri14
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Great! I'm curious to know whether the scope is mandatory for the title, or if just having the title and subject is enough?
Drawing inspiration from the description provided in https://github.com/amannn/action-semantic-pull-request for scope definition:
feat(ui): Add `Button` component
^ ^ ^
| | |__ Subject
| |_______ Scope
|____________ Type
|
Scope isn't mandatory for the PR title b/c rootulp#43 passed CI |
Thanks for testing this out! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1539 by validating that PR titles have a conventional commit prefix
Testing