Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: download celestia-app-maintainers key in verify signature script #2665

Merged
merged 1 commit into from
Oct 15, 2023
Merged

fix: download celestia-app-maintainers key in verify signature script #2665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,12 @@ If you use a pre-built binary, you may also want to verify the checksums and sig
You should see output like this:

```shell
gpg: Signature made Thu Sep 21 14:39:26 2023 EDT
gpg: Signature made Tue Oct 10 13:25:06 2023 UTC
gpg: using EDDSA key BF02F32CC36864560B90B764D469F859693DC3FA
gpg: Good signature from "celestia-app-maintainers <[email protected]>" [ultimate]
gpg: Good signature from "celestia-app-maintainers <[email protected]>" [unknown]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the [unknown]?
Also, is there a way for the signature to be trusted?

gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the owner.
Primary key fingerprint: BF02 F32C C368 6456 0B90 B764 D469 F859 693D C3FA
```

### Ledger Support
Expand Down
13 changes: 11 additions & 2 deletions scripts/signing/verify-signature.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,17 @@ fi
# PGP Key
# celestia-app-maintainers <[email protected]>
# BF02F32CC36864560B90B764D469F859693DC3FA
echo "Importing the celestia-app-maintainers public key..."
gpg --keyserver keys.openpgp.org --recv-keys BF02F32CC36864560B90B764D469F859693DC3FA
KEY_FILENAME="celestia-app-maintainers.asc"
GITHUB_URL="https://raw.githubusercontent.com/celestiaorg/celestia-app/main/scripts/signing/${KEY_FILENAME}"

echo "Downloading the celestia-app-maintainers public key"
curl -L ${GITHUB_URL} -o ${KEY_FILENAME}

echo "Importing ${KEY_FILENAME}"
gpg --import ${KEY_FILENAME}

echo "Deleting ${KEY_FILENAME}"
rm ${KEY_FILENAME}

echo "Verifying the signature of "$1" with "$2""
gpg --verify $1 $2