Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: increase MinDeposit from 1K to 10K TIA #2631

Merged
merged 7 commits into from
Oct 11, 2023
Merged

chore: increase MinDeposit from 1K to 10K TIA #2631

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
135891d
fix: increase MinDeposit from 1K to 10K TIA
Chirag018 Oct 7, 2023
693c854
readability changes
Chirag018 Oct 9, 2023
43be707
nit & blocking changes
Chirag018 Oct 10, 2023
8865773
Merge branch 'main' into increase-deposit
Chirag018 Oct 10, 2023
1209c36
Update params.md
Chirag018 Oct 10, 2023
12cf769
Merge branch 'main' into increase-deposit
Chirag018 Oct 10, 2023
ae49230
Update params.md
Chirag018 Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/default_overrides.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ func (govModule) DefaultGenesis(cdc codec.JSONCodec) json.RawMessage {
day := time.Duration(time.Hour * 24)
oneWeek := day * 7

genState.DepositParams.MinDeposit = sdk.NewCoins(sdk.NewCoin(BondDenom, sdk.NewInt(1_000_000_000))) // 1000 TIA
genState.DepositParams.MinDeposit = sdk.NewCoins(sdk.NewCoin(BondDenom, sdk.NewInt(10_000_000_000))) // 10,000 TIA
genState.DepositParams.MaxDepositPeriod = &oneWeek
genState.VotingParams.VotingPeriod = &oneWeek

Expand Down
2 changes: 1 addition & 1 deletion app/default_overrides_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func Test_newGovModule(t *testing.T) {

want := []types.Coin{{
Denom: BondDenom,
Amount: types.NewInt(1000000000),
Amount: types.NewInt(10_000_000_000),
}}

assert.Equal(t, want, govGenesisState.DepositParams.MinDeposit)
Expand Down
4 changes: 2 additions & 2 deletions specs/src/specs/params.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ are blocked by the `x/paramfilter` module.
| distribution.WithdrawAddrEnabled | true | Enables delegators to withdraw funds to a different address. | True |
| distribution.BaseProposerReward | 0 | Reward in the mint demonination for proposing a block. | True |
| distribution.BonusProposerReward | 0 | Extra reward in the mint denomination for proposers based on the voting power included in the commit. | True |
| gov.DepositParams.MinDeposit | 1000000000utia (1000 TIA) | Minimum deposit for a proposal to enter voting period. | True |
| gov.DepositParams.MinDeposit | 1_000_000_000 utia (1000 TIA) | Minimum deposit for a proposal to enter voting period. | True |
Chirag018 marked this conversation as resolved.
Show resolved Hide resolved
| gov.DepositParams.MaxDepositPeriod | 604800000000000 (1 week) | Maximum period for token holders to deposit on a proposal in nanoseconds. | True |
| gov.VotingParams.VotingPeriod | 604800000000000 (1 week) | Duration of the voting period in nanoseconds. | True |
| gov.VotingParams.VotingPeriod | 1209600000000000 (2 weeks) | Duration of the voting period in nanoseconds. | True |
Chirag018 marked this conversation as resolved.
Show resolved Hide resolved
| gov.TallyParams.Quorum | 0.334 (33.4%) | Minimum percentage of total stake needed to vote for a result to be considered valid. | True |
| gov.TallyParams.Threshold | 0.50 (50%) | Minimum proportion of Yes votes for proposal to pass. | True |
| gov.TallyParams.VetoThreshold | 0.334 (33.4%) | Minimum value of Veto votes to Total votes ratio for proposal to be vetoed. | True |
Expand Down
Loading