Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump ics23 from v0.9.0 to v0.9.1 #2585

Merged
merged 3 commits into from
Sep 28, 2023
Merged

deps: bump ics23 from v0.9.0 to v0.9.1 #2585

merged 3 commits into from
Sep 28, 2023

Conversation

cmwaters
Copy link
Contributor

ref: #2579

@avahowell
Copy link

avahowell commented Sep 27, 2023

I believe the CI is failing here because of this issue:

cosmos/ibc-go#4710 (comment)

celestia-app and ibc-go v6 is still on gogo/protobuf, but ics23 0.10.0 upgrades to cosmos/gogoproto. There is a cherrypicked branch that includes the 0.10.0 proof spec changes, but without the changes to protobuf here: https://github.com/cosmos/ics23/tree/carlos/cherrypick-%23136

Note that there is an impending ICS23 0.9.1 release that includes the spec changes but keeps a compatible protobuf impl:

https://github.com/cosmos/ics23/releases/tag/untagged-4eefd809a9cc10832e3f

@cmwaters
Copy link
Contributor Author

cmwaters commented Sep 28, 2023

Thanks for the context. I hadn't yet looked into it that deeply

Note that there is an impending ICS23 0.9.1 release that includes the spec changes but keeps a compatible protobuf impl:

Do you know when that release will be? We are very close to finalising v1 so there's uncertainty around whether such a change is possible

EDIT: I see they've just cut it (https://github.com/cosmos/ics23/releases/tag/go%2Fv0.9.1)

@cmwaters cmwaters changed the title deps: replace ics23 v0.9.0 with v0.10.0 deps: bump ics23 from v0.9.0 to v0.9.1 Sep 28, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2585 (0459fc5) into main (daed1a5) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2585      +/-   ##
==========================================
- Coverage   20.64%   20.63%   -0.02%     
==========================================
  Files         132      133       +1     
  Lines       15335    15344       +9     
==========================================
  Hits         3166     3166              
- Misses      11866    11875       +9     
  Partials      303      303              

see 2 files with indirect coverage changes

@cmwaters cmwaters marked this pull request as ready for review September 28, 2023 09:17
@cmwaters cmwaters added the backport:v1.x PR will be backported automatically to the v1.x branch upon merging label Sep 28, 2023
@celestia-bot celestia-bot requested a review from a team September 28, 2023 09:25
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @avahowell and @cmwaters !

@cmwaters cmwaters merged commit 41b3feb into main Sep 28, 2023
30 checks passed
@cmwaters cmwaters deleted the cal/ics23-bump branch September 28, 2023 13:36
mergify bot pushed a commit that referenced this pull request Sep 28, 2023
evan-forbes pushed a commit that referenced this pull request Sep 28, 2023
@avahowell avahowell mentioned this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:v1.x PR will be backported automatically to the v1.x branch upon merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants