Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove legacy upgrade proposal handlers #2270

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Aug 14, 2023

Closes #2195

@rootulp rootulp added the backport:v1.x PR will be backported automatically to the v1.x branch upon merging label Aug 14, 2023
@rootulp rootulp added this to the Mainnet milestone Aug 14, 2023
@rootulp rootulp self-assigned this Aug 14, 2023
@github-actions github-actions bot added the bot item was created by a bot label Aug 14, 2023
@rootulp rootulp marked this pull request as ready for review August 14, 2023 19:42
@rootulp rootulp requested a review from cmwaters as a code owner August 14, 2023 19:42
@codecov-commenter
Copy link

Codecov Report

Merging #2270 (a5638f3) into main (afa2559) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2270   +/-   ##
=======================================
  Coverage   21.71%   21.72%           
=======================================
  Files         129      129           
  Lines       14455    14453    -2     
=======================================
+ Hits         3139     3140    +1     
+ Misses      11010    11008    -2     
+ Partials      306      305    -1     
Files Changed Coverage Δ
app/default_overrides.go 14.95% <ø> (-1.57%) ⬇️

... and 1 file with indirect coverage changes

@rootulp rootulp enabled auto-merge (squash) August 14, 2023 19:59
Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rootulp rootulp merged commit 1fb74b0 into celestiaorg:main Aug 14, 2023
19 of 21 checks passed
mergify bot pushed a commit that referenced this pull request Aug 14, 2023
@rootulp rootulp deleted the rootulp/issue2195 branch August 14, 2023 20:22
rootulp added a commit that referenced this pull request Aug 15, 2023
This is an automatic backport of pull request #2270 done by
[Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the
[documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on
`<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you
can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

Co-authored-by: Rootul P <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:v1.x PR will be backported automatically to the v1.x branch upon merging bot item was created by a bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the unused legacy upgrade proposal handlers
4 participants