Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: reserve the last 256 namespaces for protocol use (backport #2257) #2261

Merged
merged 7 commits into from
Aug 15, 2023
Merged

feat!: reserve the last 256 namespaces for protocol use (backport #2257) #2261

merged 7 commits into from
Aug 15, 2023

Commits on Aug 14, 2023

  1. feat!: reserve the last 256 namespaces for protocol use (#2257) 

    Closes #2253

(cherry picked from commit cb8247e)

# Conflicts:
#	pkg/namespace/consts.go
#	pkg/namespace/namespace.go
#	pkg/namespace/namespace_test.go
#	pkg/shares/padding.go
#	specs/src/specs/namespace.md
    @rootulp @mergify
    rootulp authored and mergify[bot] committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    25b2df7 View commit details
    Browse the repository at this point in the history

  2. Revert "feat!: reserve the last 256 namespaces for protocol use (#2257)" 

    This reverts commit 25b2df7.
    @rootulp
    rootulp committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    b76d74c View commit details
    Browse the repository at this point in the history

  3. refactor!: un-export namespace.ValidateBlobNamespace (#2145) 

    Closes #2143

De-duplicate `ValidateBlobNamespace` and export it from `x/blob/types`
package. The namespace package needs to define its own `isBlobNamespace`
because it can't import `ValidateBlobNamespace` from `x/blob/types` as
that would introduce a circular dependency.
    @rootulp
    rootulp committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    6f8ece4 View commit details
    Browse the repository at this point in the history

  4. feat!: incorporates ParitySharesNamespace and TailPaddingNamespace in… 

    …to IsReserved function (#2194)

Closes ##2138
This PR also addresses the concerns raised in the
[comment](#2138 (comment))
by introducing a distinction between two types of reserved namespaces.
Namespaces within the range [0-255] are now identified as "Primary
Reserved Namespaces," while any other reserved namespaces beyond this
range are categorized as "Non-Primary Reserved Namespaces." Hopefully,
this differentiation provides better clarity and organization regarding
namespace allocation and usage within the code.

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
    @staheri14 @rootulp
    staheri14 authored and rootulp committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    5845ea4 View commit details
    Browse the repository at this point in the history

  5. refactor: use blob share version for padding shares (#2148) 

    Closes #2142
    @rootulp
    rootulp committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    2b9a883 View commit details
    Browse the repository at this point in the history

  6. feat!: reserve the last 256 namespaces for protocol use (#2257) 

    Closes #2253
    @rootulp
    rootulp committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    8bd17d3 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'v1.x' into mergify/bp/v1.x/pr-2257

    @rootulp
    rootulp authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    34d7cf0 View commit details
    Browse the repository at this point in the history