Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove test cmd from cli #2224

Merged
merged 3 commits into from
Aug 8, 2023
Merged

chore: remove test cmd from cli #2224

merged 3 commits into from
Aug 8, 2023

Conversation

cmwaters
Copy link
Contributor

@cmwaters cmwaters commented Aug 8, 2023

The celestia-appd currently has the command: celestia-appd tx blob TestRandBlob which I believe was used for testing scripts but shouldn't be part of the production CLI as is actually stated in a comment. This PR removes the command

@cmwaters cmwaters marked this pull request as ready for review August 8, 2023 13:06
@MSevey MSevey requested a review from a team August 8, 2023 13:07
@cmwaters cmwaters marked this pull request as draft August 8, 2023 13:29
@cmwaters
Copy link
Contributor Author

cmwaters commented Aug 8, 2023

It seems like the devops team are still depending on this command for their scripts so I'm putting this back into draft mode

@cmwaters cmwaters added the backport:v1.x PR will be backported automatically to the v1.x branch upon merging label Aug 8, 2023
@MSevey MSevey requested a review from a team August 8, 2023 14:52
@codecov-commenter
Copy link

Codecov Report

Merging #2224 (a90e9e1) into main (91799e4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2224   +/-   ##
=======================================
  Coverage   21.54%   21.54%           
=======================================
  Files         127      127           
  Lines       14329    14329           
=======================================
  Hits         3087     3087           
  Misses      10939    10939           
  Partials      303      303           

@cmwaters cmwaters merged commit e96a050 into main Aug 8, 2023
26 checks passed
@cmwaters cmwaters deleted the cal/remove-test-cmd branch August 8, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:v1.x PR will be backported automatically to the v1.x branch upon merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants