Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: shrink interface of x/mint expected keepers #2216

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Aug 5, 2023

Closes #2066

@rootulp rootulp added the warn:api breaking item will be break an API and require a major bump label Aug 5, 2023
@rootulp rootulp added this to the Post-mainnet milestone Aug 5, 2023
@rootulp rootulp requested a review from rach-id August 5, 2023 19:28
@rootulp rootulp self-assigned this Aug 5, 2023
@MSevey MSevey requested a review from a team August 5, 2023 19:28
@codecov-commenter
Copy link

Codecov Report

Merging #2216 (bc15455) into main (0c55a6e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2216   +/-   ##
=======================================
  Coverage   24.86%   24.86%           
=======================================
  Files         127      127           
  Lines       14326    14326           
=======================================
  Hits         3562     3562           
  Misses      10397    10397           
  Partials      367      367           

@rootulp rootulp added the x/mint label Aug 5, 2023
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, are these methods used in the standard mint module? if so, what for?

@cmwaters
Copy link
Contributor

cmwaters commented Aug 7, 2023

out of curiosity, are these methods used in the standard mint module? if so, what for?

They're also not used by the mainline SDK. I think it's legacy from an older refactor

Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming there is no future use for the removed methods, LGTM!

@rootulp rootulp merged commit 3ba2875 into celestiaorg:main Aug 7, 2023
21 checks passed
@rootulp rootulp deleted the rootulp/issue2066 branch August 7, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
warn:api breaking item will be break an API and require a major bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shrink the interface exposed to the mint module
6 participants