fix: end exclusive parse namespace end share range #2208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2208 +/- ##
=======================================
Coverage 24.86% 24.86%
=======================================
Files 127 127
Lines 14326 14326
=======================================
Hits 3562 3562
Misses 10397 10397
Partials 367 367
|
rach-id
commented
Aug 3, 2023
| @@ -133,7 +133,7 @@ func ParseNamespace(rawShares []shares.Share, startShare, endShare int) (appns.N | |||
| return appns.Namespace{}, fmt.Errorf("end share %d cannot be lower than starting share %d", endShare, startShare) | |||
| } | |||
|
|
|||
| if endShare >= len(rawShares) { | |||
| if endShare > len(rawShares) { | |||
There was a problem hiding this comment.
[note to reviewers]
Since the share ranges are range exclusive, then they can be == len(shares). If not, then the last share will never be proved
Co-authored-by: Rootul P <[email protected]>
rootulp
approved these changes
Aug 4, 2023
evan-forbes
approved these changes
Aug 4, 2023
rootulp
added
the
backport:v1.x
mergify bot
pushed a commit
that referenced
this pull request
May 16, 2024
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview Fixes the range to support end exclusive share ranges ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords --------- Co-authored-by: Rootul P <[email protected]> (cherry picked from commit 0c55a6e) # Conflicts: # pkg/proof/proof_test.go
rootulp
added a commit
that referenced
this pull request
May 16, 2024
…3491) This is an automatic backport of pull request #2208 done by [Mergify](https://mergify.com). Motivated by this [Slack thread](https://celestia-team.slack.com/archives/C03MP6DPLAD/p1715891011859219). It seems like we forgot to backport this fix. cc: @rach-id --------- Co-authored-by: CHAMI Rachid <[email protected]> Co-authored-by: Rootul Patel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the range to support end exclusive share ranges