Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixes mutability of the Repeat output #2140

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

staheri14
Copy link
Contributor

@staheri14 staheri14 commented Jul 20, 2023

Overview

Closes #2139

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Merging #2140 (0da10b6) into main (b77ac63) will increase coverage by 0.00%.
The diff coverage is 63.63%.

@@           Coverage Diff           @@
##             main    #2140   +/-   ##
=======================================
  Coverage   24.28%   24.28%           
=======================================
  Files         125      125           
  Lines       14248    14260   +12     
=======================================
+ Hits         3460     3463    +3     
- Misses      10432    10440    +8     
- Partials      356      357    +1     
Impacted Files Coverage Δ
x/blob/types/payforblob.go 69.54% <0.00%> (-4.02%) ⬇️
x/mint/types/constants.go 100.00% <ø> (ø)
pkg/namespace/namespace.go 60.00% <100.00%> (+10.48%) ⬆️
test/txsim/blob.go 80.00% <100.00%> (-0.65%) ⬇️
x/blob/ante/ante.go 85.00% <100.00%> (-3.47%) ⬇️
x/blob/keeper/keeper.go 80.00% <100.00%> (-2.76%) ⬇️

... and 1 file with indirect coverage changes

@staheri14 staheri14 marked this pull request as ready for review July 20, 2023 17:39
@staheri14 staheri14 enabled auto-merge (squash) July 20, 2023 17:39
@staheri14 staheri14 added this to the Mainnet milestone Jul 20, 2023
@MSevey MSevey requested a review from a team July 20, 2023 17:40
@staheri14 staheri14 merged commit ad2ee18 into main Jul 24, 2023
20 checks passed
@staheri14 staheri14 deleted the sanaz/fixes-mutability-repeat branch July 24, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unintended Side Effects: Namespace Mutability in Repeat Function
4 participants