-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the ability to trace gas consumption #2131
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2131 +/- ##
==========================================
- Coverage 25.04% 23.17% -1.87%
==========================================
Files 121 144 +23
Lines 13816 15912 +2096
==========================================
+ Hits 3460 3688 +228
- Misses 10000 11850 +1850
- Partials 356 374 +18
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not yet convinced that this is worth the maintenance costs.
Do we see ourselves tracing the consumption in the future? If not, we should close again. Opening the discussion to the reviewers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Nothing in the PR seems particularly difficult to maintain and the Python script is a separate Gist so it seems safe to merge but I'm curious what other reviewers think.
Co-authored-by: Rootul P <[email protected]>
…r-app into evan/gas-monitor-2
I guess do we see the calculations of gas being altered in the future (I'm not sure if an application can even set the |
something like this might be useful if we ever run into a gas bug, or if we ever want to fine tune resource pricing. but until then... this is a lot of extra code! |
I'm leaning towards closing and just resurrecting it as needed, similar to what we did here |
Overview
bringing back the gas monitor, not sure if we should merge this, but I'm using to regenerate all the gas charts, which can be found in #2132
Checklist