refactor: calculate namespace before loop #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
added
the
refactor
rootulp
requested review from
staheri14 and
rach-id
and removed request for
evan-forbes
Codecov Report
@@ Coverage Diff @@
## main #2113 +/- ##
==========================================
+ Coverage 25.02% 25.05% +0.02%
==========================================
Files 121 121
Lines 13806 13811 +5
==========================================
+ Hits 3455 3460 +5
Misses 9995 9995
Partials 356 356
|
rach-id
approved these changes
Jul 17, 2023
cmwaters
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2110