Skip to content

Commit

Permalink
fix: dead link (#2593)
Browse files Browse the repository at this point in the history
## Overview

fixes dead link
  • Loading branch information
evan-forbes authored Sep 28, 2023
1 parent c6f949b commit d4737b4
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion docs/architecture/adr-019-strict-inflation-schedule.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Implemented in <https://github.com/celestiaorg/celestia-app/pull/1578>

## Context

Cosmos SDK chains that use the [x/mint](https://docs.cosmos.network/v0.46/modules/mint/) module have a flexible inflation rate that increases/decreases so that the total % of tokens bonded target some value.
Cosmos SDK chains that use the [x/mint](https://github.com/cosmos/cosmos-sdk/blob/v0.46.15/x/mint/spec/README.md) module have a flexible inflation rate that increases/decreases so that the total % of tokens bonded target some value.

In contrast to a flexible inflation rate, Celestia intends on having a predictable inflation rate with the following constants:

Expand Down
4 changes: 2 additions & 2 deletions specs/src/specs/ante_handler.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# AnteHandler

Celestia makes use of a Cosmos SDK [AnteHandler](https://docs.cosmos.network/v0.46/modules/auth/03_antehandlers.html#antehandlers) in order to reject decodable sdk.Txs that do not meet certain criteria. The AnteHandler is defined in [app/ante/ante.go](https://github.com/celestiaorg/celestia-app/blob/7f97788a64af7fe0fce00959753d6dd81663e98f/app/ante/ante.go) and is invoked at multiple times during the transaction lifecycle:
Celestia makes use of a Cosmos SDK [AnteHandler](https://github.com/cosmos/cosmos-sdk/blob/v0.46.15/x/auth/spec/03_antehandlers.md) in order to reject decodable sdk.Txs that do not meet certain criteria. The AnteHandler is defined in [app/ante/ante.go](https://github.com/celestiaorg/celestia-app/blob/7f97788a64af7fe0fce00959753d6dd81663e98f/app/ante/ante.go) and is invoked at multiple times during the transaction lifecycle:

1. `CheckTx` prior to the transaction entering the mempool
1. `PrepareProposal` when the block proposer includes the transaction in a block proposal
Expand All @@ -14,7 +14,7 @@ The AnteHandler chains together several decorators to ensure the following crite
- The tx's [timeout_height](https://github.com/cosmos/cosmos-sdk/blob/22c28366466e64ebf0df1ce5bec8b1130523552c/proto/cosmos/tx/v1beta1/tx.proto#L115-L117) has not been reached if one is specified.
- The tx's [memo](https://github.com/cosmos/cosmos-sdk/blob/22c28366466e64ebf0df1ce5bec8b1130523552c/proto/cosmos/tx/v1beta1/tx.proto#L110-L113) is <= the max memo characters where [`MaxMemoCharacters = 256`](<https://github.com/cosmos/cosmos-sdk/blob/a429238fc267da88a8548bfebe0ba7fb28b82a13/x/auth/README.md?plain=1#L230>).
- The tx's [gas_limit](https://github.com/cosmos/cosmos-sdk/blob/22c28366466e64ebf0df1ce5bec8b1130523552c/proto/cosmos/tx/v1beta1/tx.proto#L211-L213) is > the gas consumed based on the tx's size where [`TxSizeCostPerByte = 10`](https://github.com/cosmos/cosmos-sdk/blob/a429238fc267da88a8548bfebe0ba7fb28b82a13/x/auth/README.md?plain=1#L232).
- The tx's feepayer has enough funds to pay fees for the tx. The tx's feepayer is the feegranter (if specified) or the tx's first signer. Note the [feegrant](https://docs.cosmos.network/v0.46/) module is enabled.
- The tx's feepayer has enough funds to pay fees for the tx. The tx's feepayer is the feegranter (if specified) or the tx's first signer. Note the [feegrant](https://github.com/cosmos/cosmos-sdk/blob/v0.46.15/x/feegrant/README.md) module is enabled.
- The tx's count of signatures <= the max number of signatures. The max number of signatures is [`TxSigLimit = 7`](https://github.com/cosmos/cosmos-sdk/blob/a429238fc267da88a8548bfebe0ba7fb28b82a13/x/auth/README.md?plain=1#L231).
- The tx's [gas_limit](https://github.com/cosmos/cosmos-sdk/blob/22c28366466e64ebf0df1ce5bec8b1130523552c/proto/cosmos/tx/v1beta1/tx.proto#L211-L213) is > the gas consumed based on the tx's signatures.
- The tx's [signatures](https://github.com/cosmos/cosmos-sdk/blob/22c28366466e64ebf0df1ce5bec8b1130523552c/types/tx/signing/signature.go#L10-L26) are valid. For each signature, ensure that the signature's sequence number (a.k.a nonce) matches the account sequence number of the signer.
Expand Down
6 changes: 3 additions & 3 deletions specs/src/specs/data_structures.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ Abstraction over transaction fees.

### Address

Celestia supports [secp256k1](https://en.bitcoin.it/wiki/Secp256k1) keys where [addresses](https://docs.cosmos.network/v0.46/basics/accounts.html#addresses) are 20 bytes in length.
Celestia supports [secp256k1](https://en.bitcoin.it/wiki/Secp256k1) keys where [addresses](https://github.com/cosmos/cosmos-sdk/blob/main/docs/architecture/adr-028-public-key-addresses.md) are 20 bytes in length.

| name | type | description |
|--------------|------------|-------------------------------------------------------------------------|
Expand Down Expand Up @@ -388,7 +388,7 @@ Wrapped transactions include additional metadata by the block proposer that is c

#### Transaction

Celestia transactions are Cosmos SDK [transactions](https://docs.cosmos.network/v0.46/core/transactions.html).
Celestia transactions are Cosmos SDK [transactions](https://github.com/cosmos/cosmos-sdk/blob/v0.46.15/docs/core/transactions.md).

### PayForBlobData

Expand Down Expand Up @@ -426,7 +426,7 @@ Celestia transactions are Cosmos SDK [transactions](https://docs.cosmos.network/

## State

The state of the Celestia chain is intentionally restricted to containing only account balances and the validator set metadata. Similar to other Cosmos SDK based chains, the state of the Celestia chain is maintained in a [multistore](https://docs.cosmos.network/main/core/store#multistore). The root of the application state is committed to in the [block header](#header) via the `AppHash`.
The state of the Celestia chain is intentionally restricted to containing only account balances and the validator set metadata. Similar to other Cosmos SDK based chains, the state of the Celestia chain is maintained in a [multistore](https://github.com/cosmos/cosmos-sdk/blob/v0.46.15/docs/core/store.md#multistore). The root of the application state is committed to in the [block header](#header) via the `AppHash`.

## Consensus Parameters

Expand Down
6 changes: 3 additions & 3 deletions specs/src/specs/public_key_cryptography.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,17 @@ A highly-optimized library is available in C (<https://github.com/bitcoin-core/s

### Public-keys

Secp256k1 public keys can be compressed to 257-bits (or 33 bytes) per the format described [here](https://docs.cosmos.network/v0.46/basics/accounts.html#public-keys).
Secp256k1 public keys can be compressed to 257-bits (or 33 bytes) per the format described [here](https://github.com/cosmos/cosmos-sdk/blob/v0.46.15/docs/basics/accounts.md#public-keys).

### Addresses

Cosmos [addresses](https://docs.cosmos.network/v0.46/basics/accounts.html#addresses) are 20 bytes in length.
Cosmos [addresses](https://github.com/cosmos/cosmos-sdk/blob/v0.46.15/docs/basics/accounts.md#addresses) are 20 bytes in length.

### Signatures

Deterministic signatures ([RFC-6979](https://tools.ietf.org/rfc/rfc6979.txt)) should be used when signing, but this is not enforced at the protocol level as it cannot be for Secp256k1 signatures.

Signatures are represented as the `r` and `s` (each 32 bytes) values of the signature. `r` and `s` take on their usual meaning (see: [SEC 1, 4.1.3 Signing Operation](https://www.secg.org/sec1-v2.pdf)). Signatures are encoded with protobuf as described [here](https://docs.cosmos.network/v0.46/core/encoding.html#transaction-encoding).
Signatures are represented as the `r` and `s` (each 32 bytes) values of the signature. `r` and `s` take on their usual meaning (see: [SEC 1, 4.1.3 Signing Operation](https://www.secg.org/sec1-v2.pdf)). Signatures are encoded with protobuf as described [here](https://github.com/cosmos/cosmos-sdk/blob/v0.46.15/docs/core/encoding.md).

### Human Readable Encoding

Expand Down
2 changes: 1 addition & 1 deletion specs/src/specs/resource_pricing.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Resource Pricing

For all standard cosmos-sdk transactions (staking, IBC, etc), Celestia utilizes
the [default cosmos-sdk mechanisms](https://docs.cosmos.network/v0.46/basics/gas-fees.html) for pricing resources. This involves
the [default cosmos-sdk mechanisms](https://github.com/cosmos/cosmos-sdk/blob/v0.46.15/docs/basics/gas-fees.md) for pricing resources. This involves
incrementing a gas counter during transaction execution each time the state is
read from/written to, or when specific costly operations occur such as signature
verification or inclusion of data.
Expand Down
2 changes: 1 addition & 1 deletion x/blob/types/payforblob.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const (
)

// MsgPayForBlobs implements the `LegacyMsg` interface.
// See: https://docs.cosmos.network/v0.46/building-modules/messages-and-queries.html#legacy-amino-legacymsgs
// See: https://github.com/cosmos/cosmos-sdk/blob/v0.46.15/docs/building-modules/messages-and-queries.md#legacy-amino-legacymsgs
var _ legacytx.LegacyMsg = &MsgPayForBlobs{}

func NewMsgPayForBlobs(signer string, blobs ...*Blob) (*MsgPayForBlobs, error) {
Expand Down
2 changes: 1 addition & 1 deletion x/qgb/overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ If more than 1/3rd of the validator set stops running their orchestrators, then

We still don't support slashing for equivocation, liveness or invalid signatures. However, if anything were to happen to the bridge, we would be able to social slash the corrupt validators and redeploy the contract.

Future versions of the QGB will support slashing. It will be enforced via the use of [vote extensions](https://docs.cosmos.network/main/building-apps/vote-extensions).
Future versions of the QGB will support slashing. It will be enforced via the use of [vote extensions](https://github.com/cometbft/cometbft/blob/v0.38.0/spec/abci/abci%2B%2B_methods.md#extendvote).

## Proofs

Expand Down
4 changes: 2 additions & 2 deletions x/upgrade/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ added to the application.
## Resources

1. <https://github.com/celestiaorg/celestia-app/pull/1491>
1. <https://docs.cosmos.network/v0.46/modules/upgrade/>
1. <https://docs.cosmos.network/v0.46/modules/gov/>
1. <https://github.com/cosmos/cosmos-sdk/blob/v0.46.15/x/upgrade/README.md>
1. <https://github.com/cosmos/cosmos-sdk/blob/v0.46.15/x/gov/README.md>

0 comments on commit d4737b4

Please sign in to comment.