Skip to content

Commit

Permalink
chore: remove import hack for protobuf any (#2846)
Browse files Browse the repository at this point in the history
Closes #744

This import hack doesn't seem necessary b/c it doesn't actually modify
`x/blobstream/types/query.pb.go`

## Testing

```
$ rm x/blobstream/types/query.pb.go
$ make proto-gen
```

and then observe that there is no `git diff` so no changes to the
already checked in `x/blobstream/types/query.pb.go` and the generated
one.

Also proto-gen passes in CI:
https://github.com/celestiaorg/celestia-app/actions/runs/6881660922/job/18718509598?pr=2846
  • Loading branch information
rootulp authored Nov 16, 2023
1 parent 7f3e4ec commit 9b5d025
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions scripts/protocgen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ done

cd ..

# temporary import hack to use cosmos-sdk implementation of Any type.
# check https://github.com/celestiaorg/celestia-app/issues/507 for more information.
sed -i 's/types "github.com\/celestiaorg\/celestia-app\/codec\/types"/types "github.com\/cosmos\/cosmos-sdk\/codec\/types"/g' \
github.com/celestiaorg/celestia-app/x/blobstream/types/query.pb.go

# move proto files to the right places
cp -r github.com/celestiaorg/celestia-app/* ./
rm -rf github.com

0 comments on commit 9b5d025

Please sign in to comment.