ci: introduce proto breakage detector (#2671)

Co-authored-by: Rootul P <[email protected]>

.github/workflows/protobuf.yml

@@ -1,4 +1,3 @@
-# protobuf runs `make proto-lint` and `make proto-gen`.
 name: protobuf
 on:
   pull_request:
@@ -32,10 +31,9 @@ jobs:
           fi
         # yamllint enable
 
-  # add this back when we start using versioning
-  # breakage:
-  #   runs-on: ubuntu-latest
-  #   steps:
-  #     - uses: actions/checkout@v3
-  #     - name: check-breakage
-  #       run: make proto-check-breaking
+  proto-check-breaking:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: proto-check-breaking
+        run: make proto-check-breaking

Makefile

@@ -5,6 +5,7 @@ DOCKER_BUF := $(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace bu
 IMAGE := ghcr.io/tendermint/docker-build-proto:latest
 DOCKER_PROTO_BUILDER := docker run -v $(shell pwd):/workspace --workdir /workspace $(IMAGE)
 PROJECTNAME=$(shell basename "$(PWD)")
+HTTPS_GIT := https://github.com/celestiaorg/celestia-app.git
 
 # process linker flags
 ldflags = -X github.com/cosmos/cosmos-sdk/version.Name=celestia-app \
@@ -57,6 +58,12 @@ proto-lint:
 	@$(DOCKER_BUF) lint --error-format=json
 .PHONY: proto-lint
 
+## proto-check-breaking: Check if there are any breaking change to protobuf definitions.
+proto-check-breaking:
+	@echo "--> Checking if Protobuf definitions have any breaking changes"
+	@$(DOCKER_BUF) breaking --against $(HTTPS_GIT)#branch=v1.x
+.PHONY: proto-check-breaking
+
 ## proto-format: Format protobuf files. Requires docker.
 proto-format:
 	@echo "--> Formatting Protobuf files"