Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native delayed delivery API to kombu #2128

Merged
merged 8 commits into from
Oct 12, 2024

Conversation

thedrow
Copy link
Member

@thedrow thedrow commented Sep 30, 2024

This PR adds the native delayed delivery API to kombu so that it can be used without Celery if required.
The PR includes an example on how to do so.

Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add official documentation.
  2. Make sure the CI passes.
  3. Make sure you're rebased on main.

Also, I'm not sure about kombu.native_delayed_delivery. Shouldn't it be in the RabbitMQ transport layer?

This feature is relevant only for RabbitMQ so it should be in the matching place in the code IMHO.

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.50%. Comparing base (96a497e) to head (9a8f525).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2128      +/-   ##
==========================================
+ Coverage   80.33%   80.50%   +0.17%     
==========================================
  Files          75       76       +1     
  Lines        9125     9179      +54     
  Branches     1350     1125     -225     
==========================================
+ Hits         7331     7390      +59     
- Misses       1600     1601       +1     
+ Partials      194      188       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thedrow
Copy link
Member Author

thedrow commented Oct 6, 2024

I thought about it and I prefer to keep the API in a separate module.
I included the example in our list of examples and added a short description which is enough documentation for most users.

The pre-commit check is failing for unrelated reasons.

Nusnus
Nusnus previously requested changes Oct 6, 2024
Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it and I prefer to keep the API in a separate module.
I included the example in our list of examples and added a short description which is enough documentation for most users.

The pre-commit check is failing for unrelated reasons.

There's no problem leaving it in a separate module, but correct me if I'm wrong, this is a transport layer feature, so it should be in the transport.

This is a cosmetic change.

Apart from that, please add the version string to the docs with v5.5 (Current 5.4.2).

We don't expect any patch release soon so the next minor release will include your new feature.

Besides LGTM, thank you!

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, Native Delayed Delivery API is to Transport layer, so logically, this should be inside the transport

@thedrow thedrow dismissed Nusnus’s stale review October 12, 2024 18:08

Addressed code review

@thedrow thedrow merged commit 5a88a28 into celery:main Oct 12, 2024
37 checks passed
@thedrow thedrow deleted the blm-376 branch October 12, 2024 18:18
@Nusnus
Copy link
Member

Nusnus commented Oct 12, 2024

CleanShot 2024-10-12 at 22 15 57@2x

Thank you for explaining @thedrow , but next time please just ping me here so I’ll review the fixes and approve the PR instead.
I need to confirm my review comments are resolved, or it loses its entire point 🤷‍♂️

Please pay attention next time, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants