Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terminate selected tasks action in admin #449

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

caoqianming
Copy link

No description provided.

@Nusnus Nusnus requested a review from auvipy October 19, 2024 21:21
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please elaborate the change a bit more? can you also verify the change?

@caoqianming
Copy link
Author

When a long task is in running state, I may need to terminate it for various reasons. So adding this action in admin is useful. I added the code and tested it and it works fine. In the beginning I was terminating tasks one by one in a for loop, later I realized that I could pass in a list, so I made some changes.

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add tests to verify this? and do not introduce any regression?

@caoqianming
Copy link
Author

Okay, I'll try.

@caoqianming
Copy link
Author

can you add tests to verify this? and do not introduce any regression?您能否添加测试来验证这一点?并且不引入任何回归?

Sorry, I have no idea to write this UNIT test. And i run python manage.py test with some errors in the picture. can you help me or give some suggestion, thank you
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants