Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'exipres', 'expire_seconds' not working normal as expected #816

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

x-7
Copy link

@x-7 x-7 commented Oct 23, 2024

related issuses:

this pr fix issue 240, not 592,beacuse fix 592 need to caulate expire_time by expire_senconds,but i dont know how to caulate it with none start_time

@x-7 x-7 marked this pull request as ready for review October 23, 2024 12:49
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests are failing, please add new tests to verify the proposed changes

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.12%. Comparing base (e3c1ade) to head (9500073).

Files with missing lines Patch % Lines
django_celery_beat/schedulers.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
+ Coverage   86.81%   87.12%   +0.31%     
==========================================
  Files          32       32              
  Lines         933      940       +7     
  Branches       74       77       +3     
==========================================
+ Hits          810      819       +9     
+ Misses        105      102       -3     
- Partials       18       19       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants