-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add creation handler (WIP) #20
base: master
Are you sure you want to change the base?
Conversation
This pull request introduces 2 alerts and fixes 2 when merging 14cef07 into 3163d6c - view on LGTM.com new alerts:
fixed alerts:
|
14cef07
to
5565fa8
Compare
This pull request introduces 2 alerts and fixes 2 when merging 5565fa8 into 3163d6c - view on LGTM.com new alerts:
fixed alerts:
|
from math import ceil | ||
from collections import namedtuple | ||
import requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can try httpx and see if any side effect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, actually, it's the old code dependency that I wrote for the prototype. I'll remove it in the next PR. It is being used to poll flower API to fetch queue length. Autoscaling implementation will change entirely.
from models.celery_custom_resource import CeleryCustomResource | ||
|
||
|
||
class FlowerDeploymentGenerator(object): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explicit inheritance from the object is not needed
This PR contains the following changes -
TODOs:
Dependent changes -
This PR to be merged only after #15 is merged.
Upcoming changes: