Skip to content

avoid update rank twice #535

avoid update rank twice

avoid update rank twice #535

GitHub Actions / Test Results (Linux, MultiThreaded) failed Jun 25, 2024 in 0s

5855 passed, 2 failed and 52 skipped

Tests failed

❌ TestResults-Linux-MultiThreaded.trx

5909 tests were completed in 1109s with 5855 passed, 2 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Rulesets.Scoring.ScoreProcessorTest 135✅ 2❌ 6s

❌ osu.Game.Tests.Rulesets.Scoring.ScoreProcessorTest

✅ TestAccuracyUpdateFromIgnoreMiss(Great)
✅ TestAccuracyUpdateFromIgnoreMiss(LargeTickHit)
✅ TestAccuracyWhenNearPerfect
✅ TestAffectsAccuracy(Good,True)
✅ TestAffectsAccuracy(Great,True)
✅ TestAffectsAccuracy(IgnoreHit,False)
✅ TestAffectsAccuracy(IgnoreMiss,False)
✅ TestAffectsAccuracy(LargeBonus,False)
✅ TestAffectsAccuracy(LargeTickHit,True)
✅ TestAffectsAccuracy(LargeTickMiss,True)
✅ TestAffectsAccuracy(Meh,True)
✅ TestAffectsAccuracy(Miss,True)
✅ TestAffectsAccuracy(None,False)
✅ TestAffectsAccuracy(Ok,True)
✅ TestAffectsAccuracy(Perfect,True)
✅ TestAffectsAccuracy(SliderTailHit,True)
✅ TestAffectsAccuracy(SmallBonus,False)
✅ TestAffectsAccuracy(SmallTickHit,True)
✅ TestAffectsAccuracy(SmallTickMiss,True)
✅ TestAffectsCombo(Good,True)
✅ TestAffectsCombo(Great,True)
✅ TestAffectsCombo(IgnoreHit,False)
✅ TestAffectsCombo(IgnoreMiss,False)
✅ TestAffectsCombo(LargeBonus,False)
✅ TestAffectsCombo(LargeTickHit,True)
✅ TestAffectsCombo(LargeTickMiss,True)
✅ TestAffectsCombo(Meh,True)
✅ TestAffectsCombo(Miss,True)
✅ TestAffectsCombo(None,False)
✅ TestAffectsCombo(Ok,True)
✅ TestAffectsCombo(Perfect,True)
✅ TestAffectsCombo(SliderTailHit,True)
✅ TestAffectsCombo(SmallBonus,False)
✅ TestAffectsCombo(SmallTickHit,False)
✅ TestAffectsCombo(SmallTickMiss,False)
✅ TestBeatmapWithALotOfObjectsDoesNotOverflowClassicScore(osu.Game.Rulesets.Catch.CatchRuleset)
✅ TestBeatmapWithALotOfObjectsDoesNotOverflowClassicScore(osu.Game.Rulesets.Mania.ManiaRuleset)
✅ TestBeatmapWithALotOfObjectsDoesNotOverflowClassicScore(osu.Game.Rulesets.Osu.OsuRuleset)
✅ TestBeatmapWithALotOfObjectsDoesNotOverflowClassicScore(osu.Game.Rulesets.Taiko.TaikoRuleset)
✅ TestComboBreak
✅ TestEmptyBeatmap(Classic)
✅ TestEmptyBeatmap(Standardised)
✅ TestFourVariousResultsOneMiss(Classic,Good,Perfect,15530)
✅ TestFourVariousResultsOneMiss(Classic,Great,Great,32867)
✅ TestFourVariousResultsOneMiss(Classic,LargeBonus,LargeBonus,100015)
✅ TestFourVariousResultsOneMiss(Classic,LargeTickHit,LargeTickHit,32696)
✅ TestFourVariousResultsOneMiss(Classic,LargeTickMiss,LargeTickHit,0)
✅ TestFourVariousResultsOneMiss(Classic,Meh,Great,3492)
✅ TestFourVariousResultsOneMiss(Classic,Miss,Great,0)
✅ TestFourVariousResultsOneMiss(Classic,Ok,Great,7029)
✅ TestFourVariousResultsOneMiss(Classic,Perfect,Perfect,32867)
✅ TestFourVariousResultsOneMiss(Classic,SliderTailHit,SliderTailHit,37163)
✅ TestFourVariousResultsOneMiss(Classic,SmallBonus,SmallBonus,100003)
✅ TestFourVariousResultsOneMiss(Classic,SmallTickHit,SmallTickHit,49365)
✅ TestFourVariousResultsOneMiss(Classic,SmallTickMiss,SmallTickHit,0)
✅ TestFourVariousResultsOneMiss(Standardised,Good,Perfect,154499)
✅ TestFourVariousResultsOneMiss(Standardised,Great,Great,326963)
✅ TestFourVariousResultsOneMiss(Standardised,LargeBonus,LargeBonus,1000150)
✅ TestFourVariousResultsOneMiss(Standardised,LargeTickHit,LargeTickHit,326963)
✅ TestFourVariousResultsOneMiss(Standardised,LargeTickMiss,LargeTickHit,0)
✅ TestFourVariousResultsOneMiss(Standardised,Meh,Great,34734)
✅ TestFourVariousResultsOneMiss(Standardised,Miss,Great,0)
✅ TestFourVariousResultsOneMiss(Standardised,Ok,Great,69925)
✅ TestFourVariousResultsOneMiss(Standardised,Perfect,Perfect,326963)
✅ TestFourVariousResultsOneMiss(Standardised,SliderTailHit,SliderTailHit,371627)
✅ TestFourVariousResultsOneMiss(Standardised,SmallBonus,SmallBonus,1000030)
✅ TestFourVariousResultsOneMiss(Standardised,SmallTickHit,SmallTickHit,493652)
✅ TestFourVariousResultsOneMiss(Standardised,SmallTickMiss,SmallTickHit,0)
✅ TestIsBonus(Good,False)
✅ TestIsBonus(Great,False)
✅ TestIsBonus(IgnoreHit,False)
✅ TestIsBonus(IgnoreMiss,False)
✅ TestIsBonus(LargeBonus,True)
✅ TestIsBonus(LargeTickHit,False)
✅ TestIsBonus(LargeTickMiss,False)
✅ TestIsBonus(Meh,False)
✅ TestIsBonus(Miss,False)
✅ TestIsBonus(None,False)
✅ TestIsBonus(Ok,False)
✅ TestIsBonus(Perfect,False)
✅ TestIsBonus(SliderTailHit,False)
✅ TestIsBonus(SmallBonus,True)
✅ TestIsBonus(SmallTickHit,False)
✅ TestIsBonus(SmallTickMiss,False)
✅ TestIsHit(Good,True)
✅ TestIsHit(Great,True)
✅ TestIsHit(IgnoreHit,True)
✅ TestIsHit(IgnoreMiss,False)
✅ TestIsHit(LargeBonus,True)
✅ TestIsHit(LargeTickHit,True)
✅ TestIsHit(LargeTickMiss,False)
✅ TestIsHit(Meh,True)
✅ TestIsHit(Miss,False)
✅ TestIsHit(None,False)
✅ TestIsHit(Ok,True)
✅ TestIsHit(Perfect,True)
✅ TestIsHit(SliderTailHit,True)
✅ TestIsHit(SmallBonus,True)
✅ TestIsHit(SmallTickHit,True)
✅ TestIsHit(SmallTickMiss,False)
✅ TestIsScorable(Good,True)
✅ TestIsScorable(Great,True)
✅ TestIsScorable(IgnoreHit,False)
✅ TestIsScorable(IgnoreMiss,False)
✅ TestIsScorable(LargeBonus,True)
✅ TestIsScorable(LargeTickHit,True)
✅ TestIsScorable(LargeTickMiss,True)
✅ TestIsScorable(Meh,True)
✅ TestIsScorable(Miss,True)
✅ TestIsScorable(None,False)
✅ TestIsScorable(Ok,True)
✅ TestIsScorable(Perfect,True)
✅ TestIsScorable(SliderTailHit,True)
✅ TestIsScorable(SmallBonus,True)
✅ TestIsScorable(SmallTickHit,True)
✅ TestIsScorable(SmallTickMiss,True)
✅ TestLegacyComboIncrease
✅ TestMinResults(Good,Miss)
✅ TestMinResults(Great,Miss)
✅ TestMinResults(IgnoreHit,IgnoreMiss)
✅ TestMinResults(LargeBonus,IgnoreMiss)
✅ TestMinResults(LargeTickHit,LargeTickMiss)
✅ TestMinResults(Meh,Miss)
✅ TestMinResults(Ok,Miss)
✅ TestMinResults(Perfect,Miss)
✅ TestMinResults(SliderTailHit,IgnoreMiss)
✅ TestMinResults(SmallBonus,IgnoreMiss)
✅ TestMinResults(SmallTickHit,SmallTickMiss)
✅ TestNormalGrades
❌ TestSilverGrades
	  Expected: SH
	  But was:  XH
	
❌ TestSilverGradesModsAppliedFirst
	  Expected: SH
	  But was:  XH
	
✅ TestSingleOsuHit(Classic,Great,100033)
✅ TestSingleOsuHit(Classic,Meh,8343)
✅ TestSingleOsuHit(Classic,Ok,16878)
✅ TestSingleOsuHit(Standardised,Great,1000000)
✅ TestSingleOsuHit(Standardised,Meh,83398)
✅ TestSingleOsuHit(Standardised,Ok,168724)

Annotations

Check failure on line 409 in osu.Game.Tests/Rulesets/Scoring/ScoreProcessorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Linux, MultiThreaded)

osu.Game.Tests.Rulesets.Scoring.ScoreProcessorTest ► TestSilverGrades

Failed test found in:
  TestResults-Linux-MultiThreaded.trx
Error:
    Expected: SH
    But was:  XH
  
Raw output
  Expected: SH
  But was:  XH

   at osu.Game.Tests.Rulesets.Scoring.ScoreProcessorTest.TestSilverGrades() in /home/runner/work/osu/osu/osu.Game.Tests/Rulesets/Scoring/ScoreProcessorTest.cs:line 409

1)    at osu.Game.Tests.Rulesets.Scoring.ScoreProcessorTest.TestSilverGrades() in /home/runner/work/osu/osu/osu.Game.Tests/Rulesets/Scoring/ScoreProcessorTest.cs:line 409

Check failure on line 421 in osu.Game.Tests/Rulesets/Scoring/ScoreProcessorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Linux, MultiThreaded)

osu.Game.Tests.Rulesets.Scoring.ScoreProcessorTest ► TestSilverGradesModsAppliedFirst

Failed test found in:
  TestResults-Linux-MultiThreaded.trx
Error:
    Expected: SH
    But was:  XH
  
Raw output
  Expected: SH
  But was:  XH

   at osu.Game.Tests.Rulesets.Scoring.ScoreProcessorTest.TestSilverGradesModsAppliedFirst() in /home/runner/work/osu/osu/osu.Game.Tests/Rulesets/Scoring/ScoreProcessorTest.cs:line 421

1)    at osu.Game.Tests.Rulesets.Scoring.ScoreProcessorTest.TestSilverGradesModsAppliedFirst() in /home/runner/work/osu/osu/osu.Game.Tests/Rulesets/Scoring/ScoreProcessorTest.cs:line 421