Fix 50 hit window values #529

5777 passed, 21 failed and 52 skipped

❌ TestResults-Windows-SingleThread.trx

5850 tests were completed in 1466s with 5777 passed, 21 failed and 52 skipped.

Test suite	Passed	Failed	Time
osu.Game.Tests.Visual.Editing.TestSceneEditorSaving	7✅	1❌	7s
osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation	44✅	1❌	66s
osu.Game.Tests.Visual.Ranking.TestSceneResultsScreen	2✅	19❌	480ms

❌ osu.Game.Tests.Visual.Editing.TestSceneEditorSaving

✅ TestCantExitWithoutSaving
✅ TestConfiguration
✅ TestConstructor
✅ TestDifficulty
✅ TestExitWithoutSaveFromExistingBeatmap
✅ TestHitObjectPlacement
❌ TestLengthAndStarRatingUpdated
	  Expected: greater than 0.0d
	  But was:  0.0d
	
✅ TestMetadata

❌ osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation

✅ TestAttemptPlayBeatmapMissingFails
✅ TestAttemptPlayBeatmapWrongHashFails
✅ TestBeatmapListingLinkSearchOnInitialOpen
✅ TestBeatmapOptionsInput
✅ TestConfirmationRequiredToDiscardPlaylist(False)
✅ TestConfirmationRequiredToDiscardPlaylist(True)
✅ TestConstructor
✅ TestDeleteAllScoresAfterPlaying
✅ TestDeleteScoreAfterPlaying
✅ TestExitGameFromSongSelect
✅ TestExitImmediatelyAfterCompletion
✅ TestExitMultiWithBackButton
✅ TestExitMultiWithEscape
✅ TestExitSongSelectAndImmediatelyClickLogo
✅ TestExitSongSelectWithClick
✅ TestExitSongSelectWithEscape
✅ TestExitWithHoldDisabled
✅ TestExitWithOperationInProgress
✅ TestFeaturedArtistDisclaimerDialog
✅ TestForceExitWithOperationInProgress
✅ TestMainOverlaysClosesNotificationOverlay
✅ TestMainOverlaysClosesSettingsOverlay
✅ TestMenuMakesMusic
✅ TestModSelectInput
✅ TestModsResetOnEnteringMultiplayer
✅ TestOpenModSelectOverlayUsingAction
✅ TestOpenOptionsAndExitWithEscape
✅ TestOverlayClosing
✅ TestPresentBeatmapAfterDeletion
✅ TestPushMatchSubScreenAndPressBackButtonImmediately
✅ TestPushSongSelectAndPressBackButtonImmediately
✅ TestQuickSkinEditorDoesntNukeSkin
✅ TestRetryCountIncrements
✅ TestRetryFromResults
✅ TestRetryImmediatelyAfterCompletion
✅ TestSettingsViaHotkeyFromMainMenu
✅ TestShowMedalAtResults
✅ TestSongContinuesAfterExitPlayer(False)
✅ TestSongContinuesAfterExitPlayer(True)
✅ TestSongSelectBackActionHandling
✅ TestSongSelectScrollHandling
✅ TestToolbarHiddenByUser
❌ TestTouchScreenDetectionAtSongSelect
	"wait for song select" timed out
✅ TestTouchScreenDetectionInGame
✅ TestWaitForNextTrackInMenu

❌ osu.Game.Tests.Visual.Ranking.TestSceneResultsScreen

✅ TestConstructor
✅ TestDownloadButtonInitiallyDisabled
❌ TestFetchScoresAfterShowingStatistics
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')
❌ TestResultsForUnranked
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')
❌ TestResultsWithFailingRank
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')
❌ TestResultsWithFailingRankOnLegacySkin
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')
❌ TestResultsWithoutPlayer
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')
❌ TestResultsWithPlayer(0.2d,D,51)
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')
❌ TestResultsWithPlayer(0.5d,D,21)
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')
❌ TestResultsWithPlayer(0.75d,C,11)
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')
❌ TestResultsWithPlayer(0.85d,B,9)
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')
❌ TestResultsWithPlayer(0.925d,A,5)
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')
❌ TestResultsWithPlayer(0.975d,A,1)
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')
❌ TestResultsWithPlayer(0.975d,S,0)
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')
❌ TestResultsWithPlayer(0.9999d,S,0)
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')
❌ TestResultsWithPlayer(1,X,0)
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')
❌ TestRulesetWithNoPerformanceCalculator
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')
❌ TestScaling
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')
❌ TestShowHideStatistics
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')
❌ TestShowHideStatisticsViaOutsideClick
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')
❌ TestShowStatisticsAndClickOtherPanel
	System.AggregateException : One or more errors occurred. (newValue must be finite, but is (NaN, 1). (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is (NaN, 1). (Parameter 'newValue')

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix 50 hit window values #529

Test Results (Windows, SingleThread)

Fix 50 hit window values #529

Jobs

Run details

5777 passed, 21 failed and 52 skipped

❌ TestResults-Windows-SingleThread.trx

❌ osu.Game.Tests.Visual.Editing.TestSceneEditorSaving

❌ osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation

❌ osu.Game.Tests.Visual.Ranking.TestSceneResultsScreen

Annotations

github-actions / Test Results (Windows, SingleThread)

github-actions / Test Results (Windows, SingleThread)

github-actions / Test Results (Windows, SingleThread)

github-actions / Test Results (Windows, SingleThread)

github-actions / Test Results (Windows, SingleThread)

github-actions / Test Results (Windows, SingleThread)

github-actions / Test Results (Windows, SingleThread)

github-actions / Test Results (Windows, SingleThread)

github-actions / Test Results (Windows, SingleThread)

github-actions / Test Results (Windows, SingleThread)

github-actions / Test Results (Windows, SingleThread)

Re-running jobs...