Skip to content

Commit

Permalink
chore: address deprecation warnings from unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
echeung-amzn committed Oct 25, 2024
1 parent 3326fa2 commit b8a91a2
Show file tree
Hide file tree
Showing 7 changed files with 24 additions and 24 deletions.
6 changes: 3 additions & 3 deletions test/facade/MonitoringAspect.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ describe("MonitoringAspect", () => {
ec2.InstanceClass.M4,
ec2.InstanceSize.LARGE,
),
machineImage: ec2.MachineImage.latestAmazonLinux(),
machineImage: ec2.MachineImage.latestAmazonLinux2023(),
minCapacity: 1,
maxCapacity: 10,
desiredCapacity: 5,
Expand Down Expand Up @@ -271,7 +271,7 @@ describe("MonitoringAspect", () => {
ec2.InstanceClass.M4,
ec2.InstanceSize.LARGE,
),
machineImage: ec2.MachineImage.latestAmazonLinux(),
machineImage: ec2.MachineImage.latestAmazonLinux2023(),
});

// WHEN
Expand Down Expand Up @@ -465,7 +465,7 @@ describe("MonitoringAspect", () => {
new redshift.Cluster(stack, "DummyCluster", {
masterUser: {
masterUsername: "admin",
masterPassword: SecretValue.plainText("password"),
masterPassword: SecretValue.unsafePlainText("password"),
},
vpc,
});
Expand Down
12 changes: 6 additions & 6 deletions test/facade/__snapshots__/MonitoringAspect.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/monitoring/aws-ec2/AutoScalingGroupMonitoring.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ test("snapshot test", () => {
autoScalingGroupName: "DummyASG",
vpc,
instanceType: InstanceType.of(InstanceClass.M4, InstanceSize.LARGE),
machineImage: MachineImage.latestAmazonLinux(),
machineImage: MachineImage.latestAmazonLinux2023(),
minCapacity: 1,
maxCapacity: 10,
desiredCapacity: 5,
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ test("snapshot test: all alarms", () => {
lambdaInsightsEnabled: true,
});

const lambdaFunctionAlias = lambdaFunction.currentVersion.addAlias("live", {
const lambdaFunctionAlias = lambdaFunction.addAlias("live", {
provisionedConcurrentExecutions: 1,
});

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/monitoring/aws-rds/AuroraClusterMonitoring.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ test("RDS passed into Aurora Cluster", () => {
});
const rdsCluster = new DatabaseCluster(scope, "DummyRdsCluster", {
engine: DatabaseClusterEngine.auroraMysql({
version: AuroraMysqlEngineVersion.VER_2_07_5,
version: AuroraMysqlEngineVersion.VER_2_07_10,
}),
instanceProps: {
instanceType: new InstanceType("t3.small"),
Expand Down

0 comments on commit b8a91a2

Please sign in to comment.