Skip to content

Commit

Permalink
chore: update some docs (#433)
Browse files Browse the repository at this point in the history
Some minor doc updates to reword or remove things that don't make sense in the context of the public library.

---

_By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_
  • Loading branch information
echeung-amzn authored Sep 27, 2023
1 parent dadff59 commit 064d54f
Show file tree
Hide file tree
Showing 8 changed files with 124 additions and 180 deletions.
281 changes: 113 additions & 168 deletions API.md

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions lib/common/alarm/AlarmFactory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,15 @@ export interface AddAlarmProps {

/**
* If this is defined, the alarm dedupe string is set to this exact value.
* Please be aware that you need to handle deduping for different stages (Beta, Prod...) and realms (EU, NA...) manually.
* Please be aware that you need to handle deduping for different stages (Beta, Prod...) and regions (EU, NA...) manually.
*
* @default - undefined (no override)
*/
readonly dedupeStringOverride?: string;

/**
* If this is defined, the alarm name is set to this exact value.
* Please be aware that you need to specify prefix for different stages (Beta, Prod...) and realms (EU, NA...) manually.
* Please be aware that you need to specify prefix for different stages (Beta, Prod...) and regions (EU, NA...) manually.
*/
readonly alarmNameOverride?: string;

Expand Down Expand Up @@ -436,7 +436,7 @@ export interface AlarmFactoryDefaults {
readonly evaluationPeriods?: number;

/**
* Global prefix for all alarm names. This should be something unique to avoid collisions with other CTIs.
* Global prefix for all alarm names. This should be something unique to avoid potential collisions.
* This is ignored if an alarm's dedupeStringOverride is declared.
*/
readonly alarmNamePrefix: string;
Expand Down
5 changes: 2 additions & 3 deletions lib/common/alarm/CustomAlarmThreshold.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,15 @@ export interface CustomAlarmThreshold {

/**
* If this is defined, the alarm dedupe string is set to this exact value.
* Please be aware that you need to handle deduping for different stages (Beta, Prod...) and realms (EU, NA...) manually.
* Dedupe strings are global and not unique per CTI.
* Please be aware that you need to handle deduping for different stages (Beta, Prod...) and regions (EU, NA...) manually.
*
* @default - undefined (no override)
*/
readonly dedupeStringOverride?: string;

/**
* If this is defined, the alarm name is set to this exact value.
* Please be aware that you need to specify prefix for different stages (Beta, Prod...) and realms (EU, NA...) manually.
* Please be aware that you need to specify prefix for different stages (Beta, Prod...) and regions (EU, NA...) manually.
*/
readonly alarmNameOverride?: string;

Expand Down
2 changes: 1 addition & 1 deletion lib/dashboard/widget/BitmapWidget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export class BitmapWidgetRenderingSupport extends Construct {
)
),
description:
"Custom Widget Render for Bitmap Widgets (MonitoringCDKConstructs)",
"Custom Widget Render for Bitmap Widgets (cdk-monitoring-constructs)",
handler: "index.handler",
memorySize: 128,
runtime: Runtime.NODEJS_18_X,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export class SecretsManagerMetricsPublisher extends Construct {
)
),
description:
"Custom metrics publisher for SecretsManager Secrets (MonitoringCDKConstructs)",
"Custom metrics publisher for SecretsManager Secrets (cdk-monitoring-constructs)",
handler: "index.handler",
memorySize: 128,
runtime: Runtime.NODEJS_18_X,
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/facade/__snapshots__/MonitoringAspect.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 064d54f

Please sign in to comment.