Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support the newest RFC #20

Open
InsZVA opened this issue Jan 26, 2017 · 8 comments
Open

Please support the newest RFC #20

InsZVA opened this issue Jan 26, 2017 · 8 comments

Comments

@InsZVA
Copy link

InsZVA commented Jan 26, 2017

in RFC5780, the CHANGED-ADDRESS has been replaced by OTHER-ADDRESS.
something about issue9

@ccding
Copy link
Owner

ccding commented Jan 30, 2017

I see. I will fix that when I have time.

@ccding
Copy link
Owner

ccding commented Feb 10, 2017

It seems that Google's server doesn't return an OTHER-ADDRESS. Is there anything I missed?

➜  go-stun git:(master) ✗ ./go-stun -s stun1.l.google.com:19302 -vvv
2017/02/10 15:56:30 Do Test1
2017/02/10 15:56:30 Send To: 64.233.186.127:19302
2017/02/10 15:56:30
00000000  00 01 00 18 21 12 a4 42  f0 22 9f 7e 66 06 79 38  |....!..B.".~f.y8|
00000010  f9 6e 01 9e 80 22 00 0c  53 74 75 6e 43 6c 69 65  |.n..."..StunClie|
00000020  6e 74 00 00 80 28 00 04  ff 6d 56 44              |nt...(...mVD|
2017/02/10 15:56:30
00000000  01 01 00 0c 21 12 a4 42  f0 22 9f 7e 66 06 79 38  |....!..B.".~f.y8|
00000010  f9 6e 01 9e 00 20 00 08  00 01 f6 0a a1 46 d8 bd  |.n... .......F..|
2017/02/10 15:56:30 Received: {packet nil: false, local: 128.84.124.255:55064, remote: 64.233.186.127:19302, changed: <nil>, other: <nil>, identical: false}
Server error: no changed address.
➜  go-stun git:(master) ✗

@ccding
Copy link
Owner

ccding commented Apr 26, 2017

For people interested in this, please check the dev branch.

@GlenDC
Copy link

GlenDC commented May 10, 2017

@ccding why is this in a dev branch and when will this be moved onto master? And is there something I can do to help this progress faster?

@ccding
Copy link
Owner

ccding commented May 10, 2017

@GlenDC because the code doesn't seem to work. I am not sure what I did wrong

@ccding
Copy link
Owner

ccding commented May 10, 2017

@GlenDC In RFC5780, the CHANGED-ADDRESS has been replaced by OTHER-ADDRESS. But the problem is, Google's server doesn't return either CHANGED-ADDRESS or OTHER-ADDRESS, while one of them is required by any RFC. I am sure I did something wrong (either in the code or reading the RFCs), but I didn't mange to figure it out.

@GlenDC
Copy link

GlenDC commented May 10, 2017

Cool, I'll try to look into it, can't promise I will get further than you though!

And I just noticed that your master branch seems to be on par with your dev branch, so I guess the dev branch is no longer needed?

@ccding
Copy link
Owner

ccding commented May 10, 2017

I guess I mistakenly pushed the patch to master when fixing the readme issue. Anyways, I don't think it matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants