Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding rebeca from cyberpunk edgerunners holding javascript the definitive guide #683

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

adding rebeca from cyberpunk edgerunners holding javascript the definitive guide #683

wants to merge 4 commits into from

Conversation

ViniciusTheCoder
Copy link

@ViniciusTheCoder ViniciusTheCoder commented Jun 17, 2024 •
edited
Loading

rebs is my favorite character from the anime and i think that this image is very nice :D

@gboncoffee
Copy link
Contributor

OMG REBECCA 🥰

cat-milk
cat-milk approved these changes Jul 14, 2024
View reviewed changes
Copy link
Owner

@cat-milk cat-milk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey could you change the casing on the file name to match the one outlined in the readme?

@cat-milk cat-milk added the Bad filename The filename doesnt match the repo style or just isnt descriptive label Jul 14, 2024
@ViniciusTheCoder
Copy link
Author

ViniciusTheCoder commented Jul 15, 2024 •
edited
Loading

Done, i renamed to 'Rebeca_Sunrise_Javascript_The_Definitive_Guide.jpg', is it ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cat-milk cat-milk cat-milk approved these changes

Assignees
No one assigned
Labels
Bad filename The filename doesnt match the repo style or just isnt descriptive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ViniciusTheCoder @gboncoffee @cat-milk