Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make request_token and context optional based on skip parameters #168

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mehrad77
Copy link

As specified in the Protecting Out-of-Band Actions section of the Castle documentation, if we need to make requests to the Filter/Risk API from the server side, we can pass the skip_request_token_validation or skip_context_validation parameters to make request_token and context optional. However, this behavior is not currently reflected in the type definitions, so we have to use // @ts-expect-error in our codebase.

This merge request updates the models so that when any of these skip parameters are passed, the corresponding field becomes optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant