Include RequestInterface as argument in should_retry_callback #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added RequestInterface as argument to the should_retry_callback
Description
Make it possible to use request based values to decide if retry should happen or not.
Motivation and context
By adding the
RequestInterface
it's now possible to use theshould_retry_callback
to only retry based on headers in the request.An example would be to only retry if against a remote api that implement "Idempotency" based on unique token in request headers, but only for non-GET requests.
So if it's a POST request and the request header is set, then it can be safely retried.
How has this been tested?
Updated unit tests to include the new argument and use of it
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
If you're unsure about any of these, don't hesitate to ask.