Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include RequestInterface as argument in should_retry_callback #40

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

Nicolai-
Copy link
Contributor

Added RequestInterface as argument to the should_retry_callback

Description

Make it possible to use request based values to decide if retry should happen or not.

Motivation and context

By adding the RequestInterface it's now possible to use the should_retry_callback to only retry based on headers in the request.
An example would be to only retry if against a remote api that implement "Idempotency" based on unique token in request headers, but only for non-GET requests.
So if it's a POST request and the request header is set, then it can be safely retried.

How has this been tested?

Updated unit tests to include the new argument and use of it

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask.

@Nicolai- Nicolai- marked this pull request as ready for review September 11, 2024 09:18
@caseyamcl caseyamcl self-assigned this Sep 11, 2024
@caseyamcl caseyamcl added this to the 2.11 milestone Sep 11, 2024
@caseyamcl caseyamcl merged commit 4cd2cd0 into caseyamcl:master Sep 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants