Add support for externalised sorting per language #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utils/sort-glossary.py
Outdated
| ('ve', 'Venda'), | ||
| ('vi', 'Vietnamese'), | ||
| ('vo', 'Volapük'), | ||
| ('cy', 'Welsh'), |
There was a problem hiding this comment.
@froggleston Welsh is already present above in line 47. Maybe sort items so that we can easier spot accidental duplicates?
There was a problem hiding this comment.
Great spot! I've removed the duplicates.
|
Sadly we can't add netlify builds as netlify doesn't allow system level dependencies (e.g. apt-get) at build time and we now require pyicu to be built which requires the libicu-dev package. I think this is good to go, save for the couple of small issues in the main PR message. |
elletjies
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #724 and #254 by moving away from liquid's in-built
sortfunction and to use a bespoke sorting provided bysort-glossary.py.There are two important changes:
glossary.ymlfile used to be copied into the_datafolder to act as the served content to liquid/jekyll. This has now changed in that the python script creates a_data/{lang}/glossary.ymlfile for each language and the template loads the specific data file based on the selected language. It also dumps out non-Latin characters in Unicode to avoid ambiguity in rendering - humans are not meant to read this_dataversion of the glossary!